Repository navigation
ci(install-test): make the npm jobs test npm's ant, not Apache Ant's - #228
Open
Nic-dorman wants to merge 1 commit into
Open
Nic-dorman wants to merge 1 commit into
Nic-dorman wants to merge 1 commit into
Conversation
Two npm jobs could never pass, for reasons in the tests themselves: - test npm install (Linux) failed after uninstall if any `ant` was still on PATH. GitHub's ubuntu image ships Apache Ant, also called `ant`, at /usr/bin/ant. The check now asserts that npm's own ant is gone, and the macOS and Windows uninstall steps gain the same check. - test npm install --ignore-scripts grepped for "embedded bootstrap peer", but the binary logs "No bootstrap config file; using N bundled bootstrap seed(s)" (ant-core/src/config.rs). Both strings arrived in the same commit, so the job had never been able to pass. Every "verify binary" step also ran `ant --help`, which Apache Ant answers as well. Each one now checks first that `ant` resolves to npm's install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nic-dorman
force-pushed
the
fix/install-test-npm-checks
branch
from
October 23, 2026 18:52
656bbee to
16749cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of
install-test.yml's npm jobs could never pass. Both failures were bugs in the tests, not in the package. Found while verifying #223.antwas still on PATH. GitHub's ubuntu image ships Apache Ant, which is also calledant, at/usr/bin/ant. The check now asserts that npm's ownant($(npm prefix -g)/bin/ant) is gone. The macOS and Windows uninstall steps, which didn't check removal before, gain the same check.No bootstrap config file; using N bundled bootstrap seed(s)(ant-core/src/config.rs). Both strings arrived in the same commit (b70d808), so the job had never been able to pass. The run before this fix shows the binary using the bundled seeds; only the grep was wrong.Every "verify binary" step also ran
ant --help, which Apache Ant answers too, so a broken npm install could still pass. Each one now checks first thatantresolves to npm's install.Linear issue
Closes V2-1525
Risk tier
Workflow-only change to a
workflow_dispatchjob.Compatibility
Semver impact
Test evidence
Dispatched
install-test.ymlon this branch against npm@withautonomi/ant@0.3.10(run 38378605487). All 7 jobs passed:/usr/bin/ant.The earlier run (38253772727, for #223) had the two Linux npm jobs failing for the reasons above. Its
--ignore-scriptslog shows the binary printingNo bootstrap config file; using 7 bundled bootstrap seed(s).New dependency
none
ADR
n/a
Mitigation / rollback
Revert the commit. It only touches
.github/workflows/install-test.yml, which runs only when dispatched.🤖 Generated with Claude Code