Repository navigation
Conversation
…ed response selection - Set idea checkbox to an indeterminate state when the idea is unselected but one or more of its student responses are selected - Fix IdeasSelectionState so unchecking an idea only preserves its selected responses under that idea category and does not select the same response in other idea rows - Refine header layout and instructions in IdeasSummary, AiSummary, TeacherReflection, and TeacherPresentationButton
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Improves the teacher presentation selection UX in
IdeasSummaryby showing an indeterminate checkbox state (with a tooltip) when an idea category is unselected but has selected student responses. Fixes a bug when the same response appears under multiple ideas. Refines layout/text across summary components.Changes
<mat-checkbox>inIdeasSummaryComponenttoindeterminatewhen the idea itself is not selected, but one or more of its student responses are selected."Some responses for this idea are selected") on indeterminate idea checkboxes.IdeasSelectionState(isIdeaResponseSelected,toggleIdea, andtoggleIdeaResponse) so that unchecking an idea with selected responses keeps those responses scoped to that idea category rather than marking the same response as selected in other unselected idea rows.IdeasSummaryComponent,AiSummaryComponent,TeacherReflectionComponent, andTeacherPresentationButtonComponent.ideas-summary.component.spec.tscovering the indeterminate checkbox state, tooltip behavior, and shared student response selection across multiple ideas.ideas-selection-state.spec.tsverifying standalone response scoping across multiple idea categories.Test
-) state."Some responses for this idea are selected"is shown.