Skip to content

fix(IdeasSummary): show only the latest revision for OpenResponse items - #2366

Merged
breity merged 4 commits into
developfrom
only-show-latest-revision-or-ideas-summary
Oct 28, 2026
Merged

breity merged 4 commits into
developfrom
only-show-latest-revision-or-ideas-summary

Conversation

@breity

@breity breity commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Changes

  • In IdeasSummaryComponent.generateIdeasSummary(), pass latestAnnotations instead of allAnnotations to groupIdeas() for OpenResponse components so only the latest revision per workgroup is included when grouping ideas and displaying student responses.
  • Update IdeasSummaryComponent unit tests for OpenResponse to verify that only the latest revision is included for workgroups with multiple revisions and that workgroups are excluded if an idea was only detected in an earlier revision.

Test

  1. Open Classroom Monitor for a run containing an OpenResponse component with CRater idea detection enabled and where at least one workgroup has submitted multiple revisions.
  2. In the Ideas Summary table, expand an idea row that includes a workgroup with multiple revisions.
  3. Verify that only the workgroup's latest revision is displayed (and if an idea was detected in an earlier revision but not in their latest revision, that workgroup's earlier response is not shown under that idea).

@breity breity self-assigned this Oct 28, 2026
@qltysh

qltysh Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...acher-summary-display/ideas-summary/ideas-summary.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@breity
breity merged commit e321743 into develop Oct 28, 2026
4 checks passed
@breity
breity deleted the only-show-latest-revision-or-ideas-summary branch October 28, 2026 19:46
@hirokiterashima

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.249.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants