Skip to content

fix(pull): report synced and changed resources accurately - #81

Open
TimKrieg01 wants to merge 1 commit into
VapiAI:mainfrom
TimKrieg01:fix/pull-summary-output
Open

TimKrieg01 wants to merge 1 commit into
VapiAI:mainfrom
TimKrieg01:fix/pull-summary-output

Conversation

@TimKrieg01

@TimKrieg01 TimKrieg01 commented Oct 11, 2026 •

Copy link
Copy Markdown

PR description: clarify pull drift output and update counts

Summary

This change corrects two separate parts of the pull/apply output:

  1. The drift direction summary now describes what the engine actually did when the dashboard was ahead: it synced the dashboard resource down to the local file. The label uses the down arrow to match the per-resource output.
  2. The updated totals count resources whose serialized local file content changed. The pull still writes each resource file, including when the generated content is identical; routine writes no longer inflate the summary.

The old dashboard-ahead summary entry was:

✏️  dashboard-ahead : 1  (these resources have UI edits since last pull; preserved locally)

It is now:

⬇️  dashboard-ahead : 1  (dashboard changes synced down to local)

Why

The dashboard-ahead summary text described an older pull behavior. Commit 4136fde (feat(pull): emit drift-direction labels on preserved resources + drift summary + --resolve gate) introduced the preserve-local wording and behavior. Commit 965a057 (refactor(drift): update drift label messaging and enhance pull logic) later changed the dashboard-ahead path to sync the dashboard version down when local content is unchanged. The per-resource output was updated to say “syncing down,” but the final drift summary retained the earlier “preserved locally” text. This change updates that stale summary so it agrees with the action taken by the engine.

The update totals also previously counted routine file writes as updates, even when the serialized content matched the existing file. That made clean pulls look as if every fetched resource had changed. The revised count checks whether the generated file content differs before incrementing updated; the normal write still happens either way.

apply runs the same pull path, so these reporting corrections apply to both pull and the pull stage of apply.

Verification

  • npm run build passed.
  • npm test passed: 537 tests.
  • Coverage verifies that changed file content increments updated, identical content does not, and the resource file is still written on the identical-content path.
  • No live Vapi API calls were needed for these output-only changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant