Repository navigation
fix(pull): report synced and changed resources accurately - #81
Open
TimKrieg01 wants to merge 1 commit into
Open
TimKrieg01 wants to merge 1 commit into
TimKrieg01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description: clarify pull drift output and update counts
Summary
This change corrects two separate parts of the pull/apply output:
updatedtotals count resources whose serialized local file content changed. The pull still writes each resource file, including when the generated content is identical; routine writes no longer inflate the summary.The old dashboard-ahead summary entry was:
It is now:
Why
The dashboard-ahead summary text described an older pull behavior. Commit
4136fde(feat(pull): emit drift-direction labels on preserved resources + drift summary + --resolve gate) introduced the preserve-local wording and behavior. Commit965a057(refactor(drift): update drift label messaging and enhance pull logic) later changed the dashboard-ahead path to sync the dashboard version down when local content is unchanged. The per-resource output was updated to say “syncing down,” but the final drift summary retained the earlier “preserved locally” text. This change updates that stale summary so it agrees with the action taken by the engine.The update totals also previously counted routine file writes as updates, even when the serialized content matched the existing file. That made clean pulls look as if every fetched resource had changed. The revised count checks whether the generated file content differs before incrementing
updated; the normal write still happens either way.applyruns the same pull path, so these reporting corrections apply to bothpulland the pull stage ofapply.Verification
npm run buildpassed.npm testpassed: 537 tests.updated, identical content does not, and the resource file is still written on the identical-content path.