Repository navigation
fix(rest/python): reject fulfillment line_item_ids that match no line item - #278
Open
aksharprabhudesai wants to merge 1 commit into
Conversation
damaz91
added
the
status:needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277
Description
Fulfillment methods and groups could reference
line_item_idsthat match no line item. They were skipped silently when quoting shipping, so item-based shipping promotions didn't apply and the same order could be priced two ways.Create and update now reject an unknown id with
400 INVALID_REQUEST, naming the id and listing the checkout's line items. Two test fixtures that used product ids as line item ids now omit them on create (meaning all items) or use the server-assigned ids on update. Added a regression test.Thanks @sanjanar06 for the clear write-up and reproduction.