Skip to content

feat(fas_bridge): implement logger-prefixed file naming for recordings - #12

Merged
Awesome-Ace22 merged 1 commit into
devfrom
chore/fas-data-prefix
Oct 22, 2026
Merged

Awesome-Ace22 merged 1 commit into
devfrom
chore/fas-data-prefix

Conversation

@Awesome-Ace22

@Awesome-Ace22 Awesome-Ace22 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What and why

This pull request standardizes the naming convention for data files generated by loggers, ensuring each file is clearly prefixed with the logger's name (e.g., FAS_<name>.csv). It updates the file matching logic to recognize these prefixes, refactors relevant code, and adds comprehensive tests to verify the new behavior.

File naming convention and code changes:

  • Introduced a DATA_FILE_PREFIX constant and a new data_file_name function in fas_bridge.py to ensure all FAS bridge data files are named with the FAS_<recording>.csv format.
  • Updated the _cmd_data_file method in FasBridge to use the new data_file_name function, guaranteeing consistent file naming when starting data saving.
  • Clarified and corrected documentation in recording_service.py to reflect the new naming convention for both fas_bridge and novaGround loggers.

File matching and discovery improvements:

  • Enhanced the recording_files function in recording_service.py to match files with optional logger prefixes, ensuring it finds all relevant files regardless of the logger.

Testing and validation:

  • Added a new test suite test_fas_bridge_data_file.py to verify that FAS bridge data files are always correctly prefixed and that file creation uses the proper naming convention.
  • Added a test in test_station_config.py to ensure recording_files includes logger-prefixed files and correctly filters files by recording name.

Closes UTATRocketry/Nova-Collected#28

How was this tested?

  • 1 Unit / Automated Test - CI
  • 2 Simulator Test - testing procedure with the hardware simulators
  • 3 Bench Test - testing procedure on the dev stack, with some real hardware
  • 4 Integration Test - full engine test procedure, real hardware, no propellants

Hardware impact

  • None - UI, docs or tooling only
  • Changes how a sensor is read, converted or shown
  • Changes how an actuator is commanded, or safety rules, interlocks, timeouts or sequencing → add the hardware-risk label; a lead must approve
  • Changes a message format, MQTT topic or FAS protocol that another repo depends on → title needs !, link the matching PRs:

Checklist

  • Targets dev (or main for a release/hotfix, or with a reason given above)
  • Branch is up to date ("Update branch" button)
  • No station config/calibrations, data files, secrets, .env files or build output committed
  • README/docs updated if behaviour changed

@Awesome-Ace22
Awesome-Ace22 requested a review from a team as a code owner October 21, 2026 17:40
@Awesome-Ace22
Awesome-Ace22 merged commit 49f5ffa into dev Oct 22, 2026
4 checks passed
@Awesome-Ace22
Awesome-Ace22 deleted the chore/fas-data-prefix branch October 22, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fas_bridge data files are not prefixed with the logger name

1 participant