Repository navigation
feat(fas_bridge): implement logger-prefixed file naming for recordings - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This pull request standardizes the naming convention for data files generated by loggers, ensuring each file is clearly prefixed with the logger's name (e.g.,
FAS_<name>.csv). It updates the file matching logic to recognize these prefixes, refactors relevant code, and adds comprehensive tests to verify the new behavior.File naming convention and code changes:
DATA_FILE_PREFIXconstant and a newdata_file_namefunction infas_bridge.pyto ensure all FAS bridge data files are named with theFAS_<recording>.csvformat._cmd_data_filemethod inFasBridgeto use the newdata_file_namefunction, guaranteeing consistent file naming when starting data saving.recording_service.pyto reflect the new naming convention for bothfas_bridgeandnovaGroundloggers.File matching and discovery improvements:
recording_filesfunction inrecording_service.pyto match files with optional logger prefixes, ensuring it finds all relevant files regardless of the logger.Testing and validation:
test_fas_bridge_data_file.pyto verify that FAS bridge data files are always correctly prefixed and that file creation uses the proper naming convention.test_station_config.pyto ensurerecording_filesincludes logger-prefixed files and correctly filters files by recording name.Closes UTATRocketry/Nova-Collected#28
How was this tested?
Hardware impact
hardware-risklabel; a lead must approve!, link the matching PRs:Checklist
dev(ormainfor a release/hotfix, or with a reason given above).envfiles or build output committed