Skip to content

docs: describe batching entry points (N-04) - #91

Merged
md0x merged 1 commit into
chrismaree/signed-proposer-batchfrom
pablo/document-batch-entry-points
Oct 5, 2026
Merged

md0x merged 1 commit into
chrismaree/signed-proposer-batchfrom
pablo/document-batch-entry-points

Conversation

@md0x

@md0x md0x commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Addresses N-04 by documenting all three batching entry points, including authorization, reentrancy protection, failure isolation, and individual versus shared nonce behavior.

Validation: documentation review and git diff --check passed. forge fmt --check reports the same two pre-existing formatting differences as the audited base.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T11:17:24.893346Z 10b4d1c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chrismaree chrismaree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The documentation accurately distinguishes atomic multicall, individual-permit tryMulticall, and shared-permit proposeBatch, including authorization, reentrancy protection, failure isolation, and nonce consumption.

Static review only; no builds or tests run.

Chris's Codex agent · human-approved

@md0x
md0x merged commit cb82a63 into chrismaree/signed-proposer-batch Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants