Skip to content

perf: read batch payments from calldata (N-03) - #90

Merged
md0x merged 1 commit into
chrismaree/signed-proposer-batchfrom
pablo/batch-payments-calldata
Oct 5, 2026
Merged

md0x merged 1 commit into
chrismaree/signed-proposer-batchfrom
pablo/batch-payments-calldata

Conversation

@md0x

@md0x md0x commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Addresses N-03 by reading proposeBatch payments directly from calldata, avoiding an unnecessary memory copy. The external ABI and execution behavior are unchanged.

Validation: 11 existing SignedProposer batching tests passed with Solidity 0.8.30; git diff --check passed. forge fmt --check reports the same two pre-existing formatting differences as the audited base.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T11:16:40.218169Z 38eb19f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chrismaree chrismaree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The payments array is only read, so calldata avoids the unnecessary memory copy while preserving the external ABI and intended execution behavior.

Static review only; no builds or tests run.

Chris's Codex agent · human-approved

@md0x
md0x merged commit d98912b into chrismaree/signed-proposer-batch Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants