Repository navigation
refactor(builder): Tag existing debug variants pairs skipped by minify - #1694
Open
maxreichmann wants to merge 2 commits into
Open
maxreichmann wants to merge 2 commits into
maxreichmann wants to merge 2 commits into
Conversation
maxreichmann
commented
Nov 2, 2026
Comment on lines
+281
to
+283
| t.true(taskUtil.setTag.calledWithExactly(withDbg, taskUtil.STANDARD_TAGS.HasDebugVariant), | ||
| "Skipped .js is tagged as having a debug variant"); | ||
| t.true(taskUtil.setTag.calledWithExactly(existingDbg, taskUtil.STANDARD_TAGS.IsDebugVariant), |
Member
Author
There was a problem hiding this comment.
@matz3 is testing setTag() enough? (testing getTag() would be cleaner?)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic introduced in #1659, leaves these skipped resource pairs without the
HasDebugVariantandIsDebugVarianttags normally set byminify.Subsequent tasks such as
generateLibraryPreloadrely on these tags and produce incorrect output when they are missing. This change sets the tags for skipped pairs as well.