Localized post dates to respect the publication language - #261
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe post card and post page now display dates as DD MMM YYYY when the site locale begins with en. Other locales use the default date format. The machine-readable datetime value remains unchanged. Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to English posts retain their existing date appearance, while other listed locales use localized dates. No actionable merge-blocking risk is evident. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
no issue - Post and post card dates were hardcoded to `DD MMM YYYY`, which ignores the site's publication language: only the month name was translated, leaving Western day-month-year ordering in every non-English locale - Dropped the explicit format so the `date` helper falls back to its locale-aware default (`ll`), rendering the whole date — order, separators and month name — according to the site's Publication Language - Left the machine-readable ISO value on the `datetime` attribute untouched
The default ll format renders US-style dates (Jul 4, 2026) for English, which would change the current design. English locales keep DD MMM YYYY, while other languages still get fully localized dates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9b1b159 to
d2d8ab1
Compare
Supersedes #174 by @daeho-ro, which couldn't be updated directly because the fork is owned by an organization.
Post and post-card dates were hardcoded to
DD MMM YYYY, so on non-English sites only the month name was localized and the Western day-month-year order was kept (e.g.04 7월 2026on a Korean site).{{date}}, which uses the locale-awarellformat.DD MMM YYYYfor English locales (en,en-GB,en-US, …), becausellwould otherwise change English dates to US style (Jul 4, 2026) and alter the current design.The
datetimeattribute is unchanged.🤖 Generated with Claude Code