Skip to content

Localized post dates to respect the publication language - #261

Merged
minimaluminium merged 2 commits into
mainfrom
localize-post-dates-en-format
Oct 6, 2026
Merged

minimaluminium merged 2 commits into
mainfrom
localize-post-dates-en-format

Conversation

@minimaluminium

Copy link
Copy Markdown
Member

Supersedes #174 by @daeho-ro, which couldn't be updated directly because the fork is owned by an organization.

Post and post-card dates were hardcoded to DD MMM YYYY, so on non-English sites only the month name was localized and the Western day-month-year order was kept (e.g. 04 7월 2026 on a Korean site).

  • The original commit from Localized post dates to respect the publication language #174 switches the visible date to {{date}}, which uses the locale-aware ll format.
  • The follow-up commit keeps DD MMM YYYY for English locales (en, en-GB, en-US, …), because ll would otherwise change English dates to US style (Jul 4, 2026) and alter the current design.
Publication Language Before After
English 04 Jul 2026 04 Jul 2026
Korean 04 7월 2026 2026년 7월 4일

The datetime attribute is unchanged.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 43400d29-3caf-4865-b6da-534f42d50ff1
📥 Commits

Reviewing files that changed from the base of the PR and between 9b1b159 and d2d8ab1.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c31f2fac-886b-4832-a733-cb7e31dcfcc7
📥 Commits

Reviewing files that changed from the base of the PR and between 1ce42e2 and 9b1b159.

📒 Files selected for processing (2)
  • partials/post-card.hbs
  • post.hbs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The post card and post page now display dates as DD MMM YYYY when the site locale begins with en. Other locales use the default date format. The machine-readable datetime value remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 9b1b1

English posts retain their existing date appearance, while other listed locales use localized dates. No actionable merge-blocking risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 9b1b1

The change affects 2 systems.

Changed systems: partials, post.hbs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — partials (service) was modified; 1 changed file maps to changed impact.
  • observed — post.hbs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in partials/post-card.hbs: The visible date now uses DD MMM YYYY only when the site locale begins with en; other locales use the default date format. The machine-readable datetime format is unchanged.
  • observed — Modified behavior in post.hbs: The visible date now uses DD MMM YYYY for locales matching the en prefix and the default date format otherwise; the machine-readable datetime value remains unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: post dates now follow the publication language.
Description check ✅ Passed The description explains the locale-based date formatting changes and the unchanged datetime attribute.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

daeho-ro and others added 2 commits October 6, 2026 13:50
no issue

- Post and post card dates were hardcoded to `DD MMM YYYY`, which ignores
  the site's publication language: only the month name was translated,
  leaving Western day-month-year ordering in every non-English locale
- Dropped the explicit format so the `date` helper falls back to its
  locale-aware default (`ll`), rendering the whole date — order,
  separators and month name — according to the site's Publication Language
- Left the machine-readable ISO value on the `datetime` attribute untouched
The default ll format renders US-style dates (Jul 4, 2026) for English,
which would change the current design. English locales keep DD MMM YYYY,
while other languages still get fully localized dates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@minimaluminium
minimaluminium force-pushed the localize-post-dates-en-format branch from 9b1b159 to d2d8ab1 Compare October 6, 2026 05:50
@minimaluminium
minimaluminium merged commit d7727be into main Oct 6, 2026
6 checks passed
@minimaluminium
minimaluminium deleted the localize-post-dates-en-format branch October 6, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants