Skip to content

Fixing flaky Backwards Lens Notebook test #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlarson4 merged 1 commit into from
Oct 21, 2026
Merged

Fixing flaky Backwards Lens Notebook test #1930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions demos/Backward_Lens_Demo.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,49 +843,49 @@
" <tr>\n",
" <th>0</th>\n",
" <td>0</td>\n",
" <td>6.557e-01</td>\n",
" <td>6.56e-01</td>\n",
" <td>adr, adian, umn, itia, igmatic</td>\n",
" <td>adr, adian, umn, itia, igmatic</td>\n",
" </tr>\n",
" <tr>\n",
" <th>1</th>\n",
" <td>2</td>\n",
" <td>1.442e+00</td>\n",
" <td>1.44e+00</td>\n",
" <td>EStreamFrame, ORPG, Dise, misconception, senal</td>\n",
" <td>EStreamFrame, ORPG, Dise, misconception, senal</td>\n",
" </tr>\n",
" <tr>\n",
" <th>2</th>\n",
" <td>4</td>\n",
" <td>1.329e+00</td>\n",
" <td>1.33e+00</td>\n",
" <td>Diseases, Firstly, Feet, heses, Differences</td>\n",
" <td>Diseases, Firstly, Feet, heses, Differences</td>\n",
" </tr>\n",
" <tr>\n",
" <th>3</th>\n",
" <td>6</td>\n",
" <td>1.042e+00</td>\n",
" <td>1.04e+00</td>\n",
" <td>Tycoon, 76561, Osiris, Modes, Memories</td>\n",
" <td>Tycoon, 76561, Osiris, Modes, Memories</td>\n",
" </tr>\n",
" <tr>\n",
" <th>4</th>\n",
" <td>8</td>\n",
" <td>4.872e-01</td>\n",
" <td>4.87e-01</td>\n",
" <td>Paris, Paris, Cologne, Copenhagen, Rome</td>\n",
" <td>Paris, Paris, Cologne, Copenhagen, Rome</td>\n",
" </tr>\n",
" <tr>\n",
" <th>5</th>\n",
" <td>10</td>\n",
" <td>2.749e-01</td>\n",
" <td>2.75e-01</td>\n",
" <td>Paris, Paris, Copenhagen, Cologne, Kyoto</td>\n",
" <td>Paris, Paris, Copenhagen, Cologne, Kyoto</td>\n",
" </tr>\n",
" <tr>\n",
" <th>6</th>\n",
" <td>11</td>\n",
" <td>2.609e-01</td>\n",
" <td>2.61e-01</td>\n",
" <td>Paris, Paris, Copenhagen, Marse, France</td>\n",
" <td>Paris, Paris, Copenhagen, Marse, France</td>\n",
" </tr>\n",
Expand All @@ -894,14 +894,14 @@
"</div>"
],
"text/plain": [
" layer VJP norm raw FF2 bottom tokens \\\n",
"0 0 6.557e-01 adr, adian, umn, itia, igmatic \n",
"1 2 1.442e+00 EStreamFrame, ORPG, Dise, misconception, senal \n",
"2 4 1.329e+00 Diseases, Firstly, Feet, heses, Differences \n",
"3 6 1.042e+00 Tycoon, 76561, Osiris, Modes, Memories \n",
"4 8 4.872e-01 Paris, Paris, Cologne, Copenhagen, Rome \n",
"5 10 2.749e-01 Paris, Paris, Copenhagen, Cologne, Kyoto \n",
"6 11 2.609e-01 Paris, Paris, Copenhagen, Marse, France \n",
" layer VJP norm raw FF2 bottom tokens \\\n",
"0 0 6.56e-01 adr, adian, umn, itia, igmatic \n",
"1 2 1.44e+00 EStreamFrame, ORPG, Dise, misconception, senal \n",
"2 4 1.33e+00 Diseases, Firstly, Feet, heses, Differences \n",
"3 6 1.04e+00 Tycoon, 76561, Osiris, Modes, Memories \n",
"4 8 4.87e-01 Paris, Paris, Cologne, Copenhagen, Rome \n",
"5 10 2.75e-01 Paris, Paris, Copenhagen, Cologne, Kyoto \n",
"6 11 2.61e-01 Paris, Paris, Copenhagen, Marse, France \n",
"\n",
" normalized FF2 bottom tokens \n",
"0 adr, adian, umn, itia, igmatic \n",
Expand Down Expand Up @@ -932,10 +932,11 @@
" row = (layer, position, token, joined(ff1_top[position]), joined(ff2_bottom[position]))\n",
" layer_position_rows.append(row)\n",
" normalized = vocab_logits(model, delta[-1], normalized=True)\n",
" # fp32 backends disagree in the fifth significant digit, so the norm shows three.\n",
" norm_comparison_rows.append(\n",
" (\n",
" layer,\n",
" f\"{float(delta[-1].norm()):.3e}\",\n",
" f\"{float(delta[-1].norm()):.2e}\",\n",
" joined(ff2[-1].topk(5, largest=False).indices),\n",
" joined(normalized.topk(5, largest=False).indices),\n",
" )\n",
Expand Down
Loading