Repository navigation
fix(wgbridge): replace deprecated AsyncFd::with_interest with AsyncFd::register_with_interest - #997
Merged
Merged
Conversation
…::register_with_interest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
AsyncFd::with_interestwithAsyncFd::register_with_interestinwgbridge-rs/src/transport/ip_recv.rs.Why
In recent versions of Tokio (1.53+),
AsyncFd::with_interestwas deprecated because it lacks I/O safety bounds. UsingAsyncFd::register_with_interestresolves the deprecation warning. Sinceset_nonblocking(&fd)is called directly prior to registration, the non-blocking safety requirement is satisfied.