Repository navigation
Clarify custom blocklists and download added lists immediately - #994
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users looking for a custom blocklist in Advanced options currently find “Additional host files”, with no explanation that Minimal mode ignores them. Adding a URL also saves it without downloading its contents (#956).
Rename the setting to “Custom blocklists”, explain the HTTPS hosts-file format, and keep list management available in every mode of the GitHub/F-Droid builds. Show a persistent notice for Minimal and Research modes. The Play build hides blocklist management, manual updates and automatic-update controls, and rejects direct entry to the blocklist screen. Those ineffective controls were exposed before this PR. In active modes, explain that browser tracker protection defaults off.
Adding or editing a list now queues the existing download worker immediately. Offline requests wait for connectivity, cached hosts remain intact until downloading succeeds, and the screen shows pending work, per-list timestamps and errors. An Update action allows retries; list mutations are disabled during running downloads but remain available while waiting offline. Enabling an uncached list also queues a download. Filtering policy is unchanged.
Validation:
git diff --checkpasses.Addresses #956; the reporter's exact blocklist and configuration remain unknown.