Repository navigation
DDIR: count keeps its sign, as DD's count - #933
Merged
Merged
Conversation
A key's count is the sum of its diffs whenever that is not zero. Before, both backends dropped a count that was not positive, so a negative accumulation was invisible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDIR's `count` dropped any count that was not positive, on both backends.
DD's `count` emits the accumulated diff whatever its sign, and a negative count is how a program finds a negative accumulation.
A key's count is now the sum of its diffs whenever that is not zero.
A key whose values cancel still has no count, as in DD, where the reducer never sees a zero accumulation.
`tests/count.rs` checks positive, negative, mixed-sign, and cancelling keys on both backends at 1 and 3 workers.
Restoring the `> 0` test in the corgi backend makes it fail.
`cargo test -p interactive -p ddir-server` passes.
It merges cleanly with #932.
🤖 Generated with Claude Code