Repository navigation
Conversation
bumpy produced camelCase and camel produced BumpyCase, the reverse of the help text. A convention given as a symbol, as YAML configuration supplies it, was ignored. The Subversion add check read $! where it needed $?, the exit status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mvandervoord
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto/generate_module.rbhad three bugs:bumpyandcamelwere reversed.bumpyproducedmadScienceandcamelproducedMadScience, the opposite of the script's own help text (bumpy - BumpyCaseFilenames,camel - camelCaseFilenames). See Module Generator naming conventions 'bumpy' and 'camel' are reversed. Ceedling#518 and In generate_module.rb 'bumpy' and 'camel' naming conventions are exchanged. #523.:naming: :snakesupplies one, and file names silently kept their typed case.svn addsuccess check read$!, the last exception, rather than$?, the child process status. A successful add could therefore raiseNoMethodError.Testing
test/spec/generate_module_naming_spec.rbcovers each convention, symbol input, and no convention. It failed before the fix and passes after it.One existing example,
generate_module_existing_file_spec.rb"with mch pattern fails when all files exist", expectsmeh_modelwhere the generator producesmeh_Model. It fails the same way onmasterwithout this change, so this PR leaves it alone.Downstream note
Ceedling's Module Generator plugin currently swaps
bumpyandcamelbefore calling this script to work around the reversal (ThrowTheSwitch/Ceedling#1338). When Ceedling's Unity submodule picks up this fix, that mapping must be removed in the same change, or the names will reverse again.