Repository navigation
Name merged coverage reports by suite instead of by run - #1340
Merged
Merged
Conversation
A merged SimpleCov result is named with every merged run's own name, and the system suite records one run per child process, hundreds in all. The HTML report prints that name in the footer of each source file view, where it buried the source. coverage:report now names each report by its suites, with the system suite's run count, such as 'units, integration, system (714 runs)'. CoverageReportLabel builds the name, with its own specs run in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the combined (and system) SimpleCov HTML report, the footer of each source file view buried the source. SimpleCov names a merged result with every merged run's own name, comma-joined. The system suite records one run per child process, so the combined report's name ran to about 25,000 characters across 714 runs. The single-page report prints that name in the source dialog's footer, which is laid out never to shrink.
coverage:reportnow names each merged report by the suites it merges, with the system suite's run count. The combined footer reads… using units, integration, system (714 runs). Coverage data and percentages are unchanged, andmeta.command_namein eachcoverage.jsonshrinks the same way.tools/coverage/report_label.rb:CoverageReportLabelbuilds the name.rake coverage:specs: runs its specs, and the Linux CI job now runs that task..github/WORKFLOWS.md: documents the naming and the new task.Testing
tools/coverage/spec/report_label_spec.rb: 5 examples, written failing first.rake coverage:report. The reports are namedunits,integration,system (2 runs), andunits, integration, system (2 runs).rake specs:unitsandrake specs:integration: pass. Lint is clean.🤖 Generated with Claude Code