Repository navigation
Fix: DateField crash when ariaLabel is undefined - #1656
Open
vikrantchavan9 wants to merge 1 commit into
Open
vikrantchavan9 wants to merge 1 commit into
vikrantchavan9 wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1655
Cause: When an error message was present, DateField copied the React Aria state object after useDateField had registered segment metadata against it. The segments received the copy, so React Aria couldn’t find their metadata and crashed.
Fix: Preserve the original state object and derive the invalid styling separately from the state and errorMessage.