Repository navigation
fix: retry creating an entry when an unrelated commit moved the branch head - #1653
Open
colingreig wants to merge 1 commit into
Open
colingreig wants to merge 1 commit into
colingreig wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 344f062 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When saving hits
STALE_DATA,useUpsertItemretries only if the entry's tree key is unchanged. For a create,currentLocalTreeKeyisundefinedwhilegetTreeKey(...)always returns a string, so the comparison never matched and every create after an unrelated commit showed "This entry has been updated since it was opened".With no local tree key, the remote key is now compared against the key of an absent entry:
A create retries when the entry (and its asset directories) still don't exist on the new head, and still shows the dialog if the same slug was created meanwhile. The retry uses the checked head as
expectedHeadOid, so a further head move surfaces an error instead of overwriting.CreateItemLocalandCreateItemCollabboth passcurrentLocalTreeKey: undefinedintouseUpsertItem, so both get the fix.Tests
New
packages/keystatic/src/app/updating.test.tsx(hook-level, mocked GitHub/urql layer):Before the fix: 2 failed, 3 passed. After: 5 passed. Full
keystaticvitest project: 58 files, 707 passed, 8 skipped. eslint, prettier andtscclean. Includes a patch changeset for@keystatic/core.Refs #1626