Repository navigation
feat(protected_environments): edit deploy group membership - #659
Merged
Merged
Conversation
Let project maintainers change an existing deployment group's explicit membership mode while preserving every other protection setting. Require full preflight, renewed confirmation after uncertainty, and authoritative read-back before reporting success. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
Record the review entry point for the protected environment deploy group membership slice. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03-ai
approved these changes
Oct 18, 2026
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: deploy-group membership editing API, controller, dialog, localization, and regression coverage
- Checks: CI completed successfully (iOS SDK validation, Flutter quality gate, language policy, and triage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Project protected environments can now switch an existing deploy group's membership between direct members only and inherited members. The dialog shows the actual reported mode and requires a changed selection, exact environment name and acknowledgement before saving.
Only the selected grant's ID and
group_inheritance_typeare sent. Complete inventory/detail preflight and strict response/read-back checks preserve group identity, reported role metadata, every other deploy grant, approval rules and legacy approval count. Unknown membership and group-level rules remain read-only; account changes and uncertain writes require a fresh inspection and confirmation.Closes #658
Validation
dart format --output=none --set-exit-if-changed .flutter analyzereports no issuesbuild_runneris not applicableChecklist
devand links one issueScreenshots
Fixture-only captures show the confirmation portion of the scrollable dialog.
Notes for reviewers
GitLab's group inheritance types also apply to deploy grants. The update endpoint can report
access_levelalongside a deploygroup_id; that metadata is accepted and preserved rather than treating the grant as a role-only entry. The write disables redirects and automatic OAuth refresh/replay, maps status errors before parsing, and uses the existing strict full-rule reader.The endpoint has no atomic compare-and-set, so preflight and read-back cannot eliminate concurrent server changes. Preservation covers modelled fields. Premium/Ultimate, CI/CD, management permissions and sharing the group with the project are server requirements; no live tier, role or self-hosted version matrix was validated. Grant creation/removal and principal/role replacement are outside this slice.
See implementation and evidence.