Skip to content

feat(protected_environments): edit deploy group membership - #659

Merged
sjungwon03 merged 2 commits into
devfrom
feat/658-deploy-group-inheritance
Oct 18, 2026
Merged

sjungwon03 merged 2 commits into
devfrom
feat/658-deploy-group-inheritance

Conversation

@sjungwon03

Copy link
Copy Markdown
Member

Summary

Project protected environments can now switch an existing deploy group's membership between direct members only and inherited members. The dialog shows the actual reported mode and requires a changed selection, exact environment name and acknowledgement before saving.

Only the selected grant's ID and group_inheritance_type are sent. Complete inventory/detail preflight and strict response/read-back checks preserve group identity, reported role metadata, every other deploy grant, approval rules and legacy approval count. Unknown membership and group-level rules remain read-only; account changes and uncertain writes require a fresh inspection and confirmation.

Closes #658

Validation

  • dart format --output=none --set-exit-if-changed .
  • flutter analyze reports no issues
  • Full app and package suites: 8,514 tests passed (app 4,834; API 3,336; design system 135; models 204; secure storage 5)
  • Related controller/widget regression suite: 196 passing tests; dedicated API tests: 27 passing tests
  • API, controller and widget tests were run red before their implementation, then green
  • Localization regenerated for English, Korean, Japanese, Hindi and Chinese
  • No models changed; build_runner is not applicable
  • CI English-language policy and whitespace checks
  • Synthetic widget captures inspected at mobile and desktop widths in light and dark themes; no live GitLab validation performed

Checklist

  • Targets dev and links one issue
  • Conventional Commits with DCO sign-off
  • Test-first implementation and updated behavior documentation
  • Five locales tested at 320/800/1200 widths in light and dark themes
  • No new dependencies or third-party assets added
  • Fixtures and screenshots contain no credentials, real instance hostnames or confidential data
  • Repository text is English except supported locale translations

Screenshots

Fixture-only captures show the confirmation portion of the scrollable dialog.

Viewport Light Dark
Mobile, 390 × 844 Mobile light Mobile dark
Desktop, 1200 × 900 Desktop light Desktop dark

Notes for reviewers

GitLab's group inheritance types also apply to deploy grants. The update endpoint can report access_level alongside a deploy group_id; that metadata is accepted and preserved rather than treating the grant as a role-only entry. The write disables redirects and automatic OAuth refresh/replay, maps status errors before parsing, and uses the existing strict full-rule reader.

The endpoint has no atomic compare-and-set, so preflight and read-back cannot eliminate concurrent server changes. Preservation covers modelled fields. Premium/Ultimate, CI/CD, management permissions and sharing the group with the project are server requirements; no live tier, role or self-hosted version matrix was validated. Grant creation/removal and principal/role replacement are outside this slice.

See implementation and evidence.

Let project maintainers change an existing deployment group's explicit membership mode while preserving every other protection setting. Require full preflight, renewed confirmation after uncertainty, and authoritative read-back before reporting success.

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@github-actions github-actions Bot added area:api packages/gitlab_api — GitLab REST/GraphQL client area:ui Screens and feature UI area:docs AGENTS.md, .agents/, README and friends feat New feature labels Oct 18, 2026
Record the review entry point for the protected environment deploy group membership slice.

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Verdict: Approved

  • Reviewed: deploy-group membership editing API, controller, dialog, localization, and regression coverage
  • Checks: CI completed successfully (iOS SDK validation, Flutter quality gate, language policy, and triage)

@sjungwon03
sjungwon03 merged commit 06b33f5 into dev Oct 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:api packages/gitlab_api — GitLab REST/GraphQL client area:docs AGENTS.md, .agents/, README and friends area:ui Screens and feature UI feat New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit inherited membership for protected environment deploy groups

2 participants