Skip to content

Prefill profile IDs from QR code - #8046

Open
johanstokking wants to merge 1 commit into
v3.37from
feature/qr-prefill-version-ids
Open

johanstokking wants to merge 1 commit into
v3.37from
feature/qr-prefill-version-ids

Conversation

@johanstokking

@johanstokking johanstokking commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Closes #7924

Changes

  • Load the profile by profile ID found in the scanned QR code
  • Fix unrelated issue with some sort of race condition with the band selector

Testing

This is tested with a new Cypress test.

The reporter @alexandre-humbert who reported this in #7924 is hopefully able to test this as well.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking
johanstokking requested a review from a team as a code owner October 5, 2026 15:12
@johanstokking johanstokking added this to the v3.37.0 milestone Oct 5, 2026
@johanstokking johanstokking self-assigned this Oct 5, 2026
@github-actions github-actions Bot added the ui/web This is related to a web interface label Oct 5, 2026

@PavelJankoski PavelJankoski left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with the preselection, sometimes the device card is displayed before the model is loaded so the page crashes. We need to fix this in pkg/webui/console/containers/device-onboarding-form/type-form-section/repository-form-section/index.js

Add selector const hasModel = useSelector(state => Boolean(selectDeviceModelById(state, brand, model)))

and change showDeviceCard condition to: const showDeviceCard = hasValidType && hasModel

Image

You can testing by scanning QR code with text: LW:D0:1122334455667788:AABBCCDDEEFF0011:01AC0001, click apply and an error screen is displayed.

@johanstokking
johanstokking force-pushed the feature/qr-prefill-version-ids branch from 7ae0f23 to c05d2e6 Compare October 9, 2026 15:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device model not selected when using a QR code for registration.

2 participants