Repository navigation
Prefill profile IDs from QR code - #8046
Open
johanstokking wants to merge 1 commit into
Open
johanstokking wants to merge 1 commit into
johanstokking wants to merge 1 commit into
Conversation
PavelJankoski
requested changes
Oct 7, 2026
Contributor
There was a problem hiding this comment.
Now with the preselection, sometimes the device card is displayed before the model is loaded so the page crashes. We need to fix this in pkg/webui/console/containers/device-onboarding-form/type-form-section/repository-form-section/index.js
Add selector const hasModel = useSelector(state => Boolean(selectDeviceModelById(state, brand, model)))
and change showDeviceCard condition to: const showDeviceCard = hasValidType && hasModel
You can testing by scanning QR code with text: LW:D0:1122334455667788:AABBCCDDEEFF0011:01AC0001, click apply and an error screen is displayed.
johanstokking
force-pushed
the
feature/qr-prefill-version-ids
branch
from
October 9, 2026 15:20
7ae0f23 to
c05d2e6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7924
Changes
Testing
This is tested with a new Cypress test.
The reporter @alexandre-humbert who reported this in #7924 is hopefully able to test this as well.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.