bugfix(network): Release the disconnect chat message after sending it

[tintinhamans]

sendDisconnectChat never releases the reference it gets from newInstance. sendLocalCommandDirect balances its own attach, so every chat line typed on the disconnect screen leaks one NetDisconnectChatCommandMsg. Every other send function, including sendChat right above it, ends with msg->detach().

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4e12701b-7653-4849-af2e-596c318cc188

---

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6761c and eda71ed.

---

📒 Files selected for processing (1)

• Core/GameEngine/Source/GameNetwork/ConnectionManager.cpp

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge and fixes the disconnect chat memory leak.

Summary

Fixes a memory leak in sendDisconnectChat by releasing the message after sending it and showing it locally.

• Disconnect chat messages release their reference after handling.

_{Reviews (1) · Last reviewed commit: "bugfix(network): Release the disconnect ..." · Reviewed by Greptile}