Skip to content

feat(text): Load extra string files next to the string table #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tintinhamans wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(text): Load extra string files next to the string table #3460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6130948
fix(filesystem): Only list archive subdirectories when asked
tintinhamans Oct 10, 2026
0864a33
refactor(text): Parse string files into a vector
tintinhamans Oct 10, 2026
c62f993
fix(text): Reject malformed string files
tintinhamans Oct 10, 2026
4e268ac
feat(text): Load extra string files next to the string table
tintinhamans Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Core/GameEngine/Source/Common/System/ArchiveFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,15 +150,17 @@ void ArchiveFile::getFileListInDirectory(const AsciiString& currentDirectory, co

void ArchiveFile::getFileListInDirectory(const DetailedArchivedDirectoryInfo *dirInfo, const AsciiString& currentDirectory, const AsciiString& searchName, FilenameList &filenameList, Bool searchSubdirectories) const
{
DetailedArchivedDirectoryInfoMap::const_iterator diriter = dirInfo->m_directories.begin();
for (; diriter != dirInfo->m_directories.end(); ++diriter) {
const DetailedArchivedDirectoryInfo *tempDirInfo = &(diriter->second);
AsciiString tempDirName = currentDirectory;
if (!tempDirName.isEmpty() && !tempDirName.endsWith("\\")) {
tempDirName.concat('\\');
if (searchSubdirectories) {
DetailedArchivedDirectoryInfoMap::const_iterator diriter = dirInfo->m_directories.begin();
for (; diriter != dirInfo->m_directories.end(); ++diriter) {
const DetailedArchivedDirectoryInfo *tempDirInfo = &(diriter->second);
AsciiString tempDirName = currentDirectory;
if (!tempDirName.isEmpty() && !tempDirName.endsWith("\\")) {
tempDirName.concat('\\');
}
tempDirName.concat(tempDirInfo->m_directoryName);
getFileListInDirectory(tempDirInfo, tempDirName, searchName, filenameList, searchSubdirectories);
}
tempDirName.concat(tempDirInfo->m_directoryName);
getFileListInDirectory(tempDirInfo, tempDirName, searchName, filenameList, searchSubdirectories);
}

ArchivedFileInfoMap::const_iterator fileiter = dirInfo->m_files.begin();
Expand Down
Loading
Loading