Skip to content

Plain string files cannot be read from within .big files #255

Description

@xezon

Operating System: Any

Commit/build: None

Original game source: Any

*Reproducible in the original Generals Zero Hour?
Multiplayer affected?
Are you using any mods? (like Gentool, Rise of the Reds or Contra)

Issue explanation

Plain string files cannot reliably be read from .big files as they rely on line ending conversions of text mode file IO and .big file contents can only be opened in binary mode.

Activity

  1. added
    EnhancementIs new feature or request
    MinorSeverity: Minor < Major < Critical < Blocker
    on Feb 28, 2025
  2. removed theissue type on Mar 4, 2025
  3. willherzog commented on Mar 5, 2025

    @willherzog

    Is this primarily a cross-platform issue? If you open a .big archive in FinalBig (for example), you can easily preview the original plain text files (although FinalBig might simply be assuming the line endings are all CRLF):

    Image

  4. self-assigned this
    on Oct 10, 2026
  5. tintinhamans commented on Oct 10, 2026

    @tintinhamans

    Had a look at this for #3460. The str reader splits on \n and treats \r as whitespace, so binary vs text mode makes no difference. Tried multi-line strings, escapes, speech, LF/CRLF/mixed, loose and in a big, all parse the same.

    Data\Generals.str in a big already replaces generals.csf today. Loading extra str/csf next to it from bigs is what #3460 adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EnhancementIs new feature or requestMinorSeverity: Minor < Major < Critical < Blocker

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions