Repository navigation
fix(dispatch): close idle NNTP sockets after the idle-release delay - #291
Merged
Merged
Conversation
Without WebDAV pools sharing the budget, download workers kept their sockets open forever once the queue drained, so the pool panel showed every socket as connected with nothing downloading and the provider's connection slots stayed held. Idle workers now release their socket after idle_release (30s) in every configuration, as SABnzbd does, and reconnect when new work arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thedancingdeveloper
enabled auto-merge
October 24, 2026 02:31
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without WebDAV pools sharing the server budget, download workers kept every NNTP socket open forever once the queue drained. On sabnzbd.sprooty.com (v1.7.0-beta.8) the pool panel showed ~250 sockets
connectedwith an empty queue andactive: 0, and the provider's connection slots stayed held.Idle workers now release their socket after
idle_release(30s) in every configuration, as SABnzbd does, and reconnect when new work arrives.next_work_item: drop thebudget.has_pools()gate on the idle-release checkwithout_webdav_idle_workers_keep_their_sockets→without_webdav_idle_workers_close_their_socketsChecks:
cargo nextest run -p nzb-dispatch(111 passed), clippy-D warnings, fmt.🤖 Generated with Claude Code