Repository navigation
Conversation
What: 16 timing-path cases on asap7, gf180mcu, Nangate45, sky130hd and sky130hs, each run with -phases LEGACY. Why: the golden logs show that the later changes of the setup repair stack leave LEGACY unchanged. How: DEF, SDC and Tcl per case with golden logs; no code change. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of new integration tests (repair_setup_path1 through repair_setup_path19) to the resizer test suite, updating both Bazel and CMake build configurations. Additionally, it modifies TestResizerMt.cc to explicitly call sta_->findRequireds() before retrieving the worst slack path, ensuring required times are properly calculated. I have no feedback to provide as there are no review comments to address.
This was referenced Oct 17, 2026
maliberty
reviewed
Oct 17, 2026
maliberty
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 12. This stack adds the experimental PARALLEL_EVAL setup repair policy in steps that can be reviewed one at a time, one commit per PR. Base:
master.Summary
Changes
repair_setup_pathNruns-phases LEGACYon a critical path slice and keeps the repaired path in a golden log.Stack