Skip to content

test: Add LEGACY repair setup path regressions - #11794

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-rsz-setup-path-tests
Oct 17, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-rsz-setup-path-tests

Conversation

@jhkim-pii

@jhkim-pii jhkim-pii commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Part 1 of 12. This stack adds the experimental PARALLEL_EVAL setup repair policy in steps that can be reviewed one at a time, one commit per PR. Base: master.

Summary

  • Add golden regressions for the LEGACY setup repair policy, so the later PRs of this stack show that they leave LEGACY unchanged.

Changes

  • 16 timing-path cases (DEF, SDC and Tcl) on five platforms: asap7, gf180mcu, Nangate45, sky130hd and sky130hs.
  • Each case repair_setup_pathN runs -phases LEGACY on a critical path slice and keeps the repaired path in a golden log.
flowchart LR
  C["16 path cases<br/>5 platforms"] --> L["repair_setup_pathN<br/>-phases LEGACY"]
  L --> G["golden .ok"]
Loading

Stack

  1. test: Add LEGACY repair setup path regressions #11794 test: Add LEGACY repair setup path regressions (this PR)
  2. rsz: Remove MT1, MEASURED_VT_SWAP, LEGACY_MT and the RSZ_* knobs #11795 rsz: Remove MT1, MEASURED_VT_SWAP, LEGACY_MT and the RSZ_* knobs
  3. rsz: Add the setup repair profiler #11796 rsz: Add the setup repair profiler
  4. rsz: Model side paths in the Mt delay estimator #11797 rsz: Model side paths in the Mt delay estimator
  5. rsz: Add the RebufferMt buffer-tree move #11798 rsz: Add the RebufferMt buffer-tree move
  6. rsz: Add the experimental PARALLEL_EVAL setup repair policy #11799 rsz: Add the experimental PARALLEL_EVAL setup repair policy
  7. rsz: Add SplitLoadMt to PARALLEL_EVAL #11800 rsz: Add SplitLoadMt to PARALLEL_EVAL
  8. rsz: Add SwapPinsMt to the PARALLEL_EVAL WNS tail #11801 rsz: Add SwapPinsMt to the PARALLEL_EVAL WNS tail
  9. rsz: Add UnbufferMt to the PARALLEL_EVAL WNS tail #11802 rsz: Add UnbufferMt to the PARALLEL_EVAL WNS tail
  10. rsz: Add SizeDownFanoutMt to the PARALLEL_EVAL WNS tail #11803 rsz: Add SizeDownFanoutMt to the PARALLEL_EVAL WNS tail
  11. rsz: Add the per-move analysis and the rebuffer accuracy report #11804 rsz: Add the per-move analysis and the rebuffer accuracy report
  12. doc: Update the rsz setup repair architecture #11805 doc: Update the rsz setup repair architecture

What: 16 timing-path cases on asap7, gf180mcu, Nangate45, sky130hd and
sky130hs, each run with -phases LEGACY.

Why: the golden logs show that the later changes of the setup repair
stack leave LEGACY unchanged.

How: DEF, SDC and Tcl per case with golden logs; no code change.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii jhkim-pii self-assigned this Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive set of new integration tests (repair_setup_path1 through repair_setup_path19) to the resizer test suite, updating both Bazel and CMake build configurations. Additionally, it modifies TestResizerMt.cc to explicitly call sta_->findRequireds() before retrieving the worst slack path, ensuring required times are properly calculated. I have no feedback to provide as there are no review comments to address.

Comment thread src/rsz/test/repair_setup_path6.tcl
@jhkim-pii
jhkim-pii marked this pull request as ready for review October 17, 2026 05:16
@jhkim-pii
jhkim-pii requested a review from a team as a code owner October 17, 2026 05:16
@maliberty
maliberty merged commit 8a0a317 into The-OpenROAD-Project:master Oct 17, 2026
21 checks passed
@maliberty
maliberty deleted the secure-rsz-setup-path-tests branch October 17, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants