Repository navigation
Conversation
latsnq is a positive-enable latch with an active-low set, not a negative-enable latch. Mapping $_DLATCH_N_ to it ignored the enable polarity and left SETN unconnected. Drop the mapping so yosys handles negative-enable latches itself. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Member
Author
|
Thanks @nanocoh |
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
$_DLATCH_N_techmap entry fromflow/platforms/gf180/cells_latch.v.gf180mcu_fd_sc_mcu9t5v0__latsnq_1is a positive-enable latch with an active-low set, not a negative-enable latch. The old mapping ignored the enable polarity and left SETN unconnected. Without the mapping, yosys handles negative-enable latches itself (for example, by inverting the enable into$_DLATCH_P_).$_DLATCH_P_→latq_1is unchanged.