Skip to content

Fix gf180/cells_latch.v to tie-off preset - #4709

Closed
maliberty wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:gf180-dangling-preset
Closed

maliberty wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:gf180-dangling-preset

Conversation

@maliberty

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Oct 21, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T03:59:51.276360Z 51ba0f8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the $DLATCH_N latch cell mapping in flow/platforms/gf180/cells_latch.v by explicitly tying the active-low set input (SETN) of the gf180mcu_fd_sc_mcu9t5v0__latsnq_1 cell to a constant high signal (1'b1). This ensures the set functionality is disabled as expected for this latch type. There are no review comments to address, and the changes look correct.

@maliberty maliberty closed this Oct 21, 2026
@maliberty
maliberty deleted the gf180-dangling-preset branch October 21, 2026 04:04
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 36aced9 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants