Repository navigation
fix(report): include flows that fail before stage logs - #4677
Merged
vvbandeira merged 2 commits intoOct 14, 2026
Merged
vvbandeira merged 2 commits into
vvbandeira merged 2 commits into
Conversation
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the report generation logic in flow/util/genReport.py to explicitly indicate when a flow did not reach its last stage, and adds a corresponding unit test in flow/test/test_genReport.py. The review feedback suggests conditionally appending the last log file information only if data['last_log'] is not empty, preventing uninformative output when a flow fails extremely early before any logs are created.
Make can fail before it creates the variant log directory. The summary then omits the failed design. Save the Make log when no stage log exists. Detect completion from the expected log, and handle empty log folders. Add CLI regression coverage for the missing-input failure and reruns. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
vvbandeira
changed the title
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Make fails before the first stage, it can leave no variant log directory, so the final report omits the failed design.
Keep the Make log for that case and report that the flow did not reach the last stage, with the failure details.
Detect completion from the expected final-stage log instead of the last filename, and report empty log directories without a crash.
The missing-input regression now counts all three designs and lists both failing runs.
Tests also cover configured variants and design nicknames, successful reruns, auxiliary logs, and empty log directories.
Local validation: eight report tests, all utility test scripts (one existing skip), Bash syntax, and Black 26.5.1.
The missing-input failure was also reproduced with the real ORFS Makefile.