Repository navigation
Include failed QoR metrics in flow reports - #4676
vvbandeira merged 4 commits into
Conversation
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request enhances QoR reporting by formatting and extracting detailed regression metrics. It introduces a helper to format exact values, logs failed metrics in checkQorMetrics.py, and updates genReport.py to parse and append these regressions to the final report. Feedback suggests specifying an explicit UTF-8 encoding when opening the log file in parse_qor_regressions to avoid potential UnicodeDecodeError crashes on systems with different default encodings.
| regressions = [] | ||
| in_regressions = False | ||
| try: | ||
| with open(filename, "r") as file: |
There was a problem hiding this comment.
Opening the file without specifying an explicit encoding uses the platform's default encoding (e.g., cp1252 on Windows). If the log file contains UTF-8 characters, this can raise a UnicodeDecodeError.\n\nSince UnicodeDecodeError inherits from ValueError (and not OSError), the except OSError: block will not catch it, causing genReport.py to crash. Specifying encoding="utf-8" ensures cross-platform compatibility and prevents unhandled exceptions.
| with open(filename, "r") as file: | |
| with open(filename, "r", encoding="utf-8") as file: |
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
genReport.pynow places each failed QoR metric's value, baseline, and limit directly under its matching failing run. It omits the optional QoR heading. The parser reads UTF-8 logs, with a regression test for non-ASCII log text.PR #4675 is the test case. Build #3 showed that its actual run label differed from the identity used by the parser, so the metrics were missing from the summary. The matching fix is in this PR.
The latest PR #4675 commit is
94e0bba3c4f21adc0db77761ec4ae942420a79a3. Merge build #5 has recorded the six expected Nangate45 metrics and the expected QoR gate failure. Jenkins has not published the final report summary yet.