Repository navigation
fix: register custom exceptions despite the target site - #1873
Merged
Merged
Conversation
Every type derived from `System.Exception` inherits `TargetSite`, which requires unreferenced code, so the generator never registered a custom exception. Under Native AOT, a snapshot of a custom exception therefore lost its own members, and comparing two of them failed because reflection is switched off. `TargetSite` only returns null where the metadata of the method was trimmed, as it always does under Native AOT, so reading it is safe. The generator now registers such an exception with all its members, like reflection finds them, and suppresses the trimming warning on the registration that reads `TargetSite`. An exception with its own unreferenceable member is still skipped.
|
vbreuss
enabled auto-merge (squash)
October 18, 2026 15:03
Contributor
Test Results 92 files 92 suites 2h 16m 14s ⏱️ Results for commit 042d0f5. |
Contributor
🚀 Benchmark ResultsDetails
|
github-actions Bot
added a commit
that referenced
this pull request
Oct 18, 2026
… the target site (#1873) by Valentin Breuß
github-actions Bot
added a commit
that referenced
this pull request
Oct 18, 2026
… the target site (#1873) by Valentin Breuß
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Every type derived from
System.ExceptioninheritsTargetSite, which requires unreferenced code, so the generator never registered a custom exception. Under Native AOT, a snapshot of a custom exception therefore lost its own members, and comparing two of them failed because reflection is switched off.TargetSiteonly returns null where the metadata of the method was trimmed, as it always does under Native AOT, so reading it is safe. The generator now registers such an exception with all its members, like reflection finds them, and suppresses the trimming warning on the registration that readsTargetSite. An exception with its own unreferenceable member is still skipped.