Skip to content

feat: add IsEqualTo expectations on IPAddress with IgnoringIPv4MappedToIPv6 - #198

Merged
vbreuss merged 1 commit into
mainfrom
feat/ipaddress-is-equal-to
Oct 16, 2026
Merged

vbreuss merged 1 commit into
mainfrom
feat/ipaddress-is-equal-to

Conversation

@vbreuss

@vbreuss vbreuss commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

An IPv4-mapped IPv6 address (e.g. from a dual-stack socket) is not equal to its IPv4 address under IPAddress.Equals, so the equality expectations on IPAddress add an option to compare them by their IPv4 address, while keeping the existing object equality options like Using(comparer).

@vbreuss vbreuss self-assigned this Oct 16, 2026
Copilot AI balanced review requested due to automatic review settings October 16, 2026 21:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Test Results

   19 files  ±  0     19 suites  ±0   18s ⏱️ +2s
1 150 tests + 38  1 149 ✅ + 38  1 💤 ±0  0 ❌ ±0 
6 868 runs  +228  6 867 ✅ +228  1 💤 ±0  0 ❌ ±0 

Results for commit 56c814d. ± Comparison against base commit c4d4d4d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

👽 Mutation Results

Mutation testing badge

aweXpect.Web

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Runtime Errors Total Detected Total Undetected Total Mutants
ThatIPAddress.IsEqualTo.cs 65.71% 23 2 0 10 2 5 0 23 12 42

The final mutation score is 65.71%

Coverage Thresholds: high:80 low:60 break:0

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.5 LTS (Noble Numbat)
AMD EPYC 7763 3.23GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.303
[Host] : .NET 8.0.32 (8.0.32, 8.0.3226.50405), X64 RyuJIT x86-64-v3
DefaultJob : .NET 8.0.32 (8.0.32, 8.0.3226.50405), X64 RyuJIT x86-64-v3

Method Mean Error StdDev Gen0 Allocated
Content_aweXpect 448.5 ns 9.00 ns 11.70 ns 0.0563 944 B
SuccessStatusCode_aweXpect 236.3 ns 3.71 ns 3.29 ns 0.0467 784 B

…ToIPv6

An IPv4-mapped IPv6 address (e.g. from a dual-stack socket) is not equal to its IPv4 address under IPAddress.Equals, so the equality expectations on IPAddress add an option to compare them by their IPv4 address, while keeping the existing object equality options like Using(comparer).
@vbreuss
vbreuss force-pushed the feat/ipaddress-is-equal-to branch from bed4619 to 56c814d Compare October 16, 2026 21:44
@vbreuss
vbreuss enabled auto-merge (squash) October 16, 2026 21:46
@sonarqubecloud

Copy link
Copy Markdown

@vbreuss
vbreuss merged commit 3b701a2 into main Oct 16, 2026
16 checks passed
@vbreuss
vbreuss deleted the feat/ipaddress-is-equal-to branch October 16, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants