Skip to content

chore: fix Sonar issues - #1121

Merged
vbreuss merged 1 commit into
mainfrom
chore/fix-sonar-issues
Oct 11, 2026
Merged

vbreuss merged 1 commit into
mainfrom
chore/fix-sonar-issues

Conversation

@vbreuss

@vbreuss vbreuss commented Oct 11, 2026

Copy link
Copy Markdown
Member

Pin GitHub Actions to full commit SHAs so a moved tag cannot change what runs in CI, and use indexed access instead of Last() on the IReadOnlyList.

Pin GitHub Actions to full commit SHAs so a moved tag cannot change what runs in CI, and use indexed access instead of Last() on the IReadOnlyList.
@vbreuss vbreuss self-assigned this Oct 11, 2026
Copilot AI balanced review requested due to automatic review settings October 11, 2026 05:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

@mergify

mergify Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@github-actions

Copy link
Copy Markdown

Test Results

     62 files  ±0       62 suites  ±0   1h 14m 49s ⏱️ - 4m 28s
 66 154 tests +4   59 203 ✅ +4   6 951 💤 ±0  0 ❌ ±0 
151 204 runs  ±0  132 065 ✅ ±0  19 139 💤 ±0  0 ❌ ±0 

Results for commit e83b4c7. ± Comparison against base commit fdd6bc2.

This pull request removes 62992 and adds 62995 tests. Note that renamed tests count towards both.
  )
)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(2416c909-fd3d-48bb-b25a-42d5db2e9244)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(292a95d7-2bb6-43cc-a8b5-6975a2d169b6)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3200e3ff-e8a1-4053-b997-e9a7a350c6e3)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(32e9a9d4-a7cc-49c6-bc14-377f11a8f4e7)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(51bd2af0-0302-42b6-a613-b25296e069ea)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(53ec5b18-17f6-4eb3-af4f-a5b2e89415fa)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(5896c52e-3591-45f5-b4d8-d94efdc49644)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(740391e1-d783-46d2-9163-b9b596d19359)
…
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(05e9ca0b-6bcd-4a26-b1c4-e3ef0610b976)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(11125f70-e32c-40cc-a124-8ad3d3a1f1a1)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(23dd2b84-8bb5-4fdd-aa5b-44ef88e6c3be)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(24401fa5-0a15-4d43-acb4-c01dc2e190e2)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(262d977b-c884-457d-b235-0ee2bfe60ed2)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(33ca7a38-799f-4d5b-a296-1129fb29afaf)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(36d97192-5cf6-4d36-b6f5-587ca0a6e7cc)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(5bb77a82-6261-4f62-ba1d-020e222cb934)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(6f842838-9cdd-4397-94e9-708b5d578916)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(746e28dd-4218-4b60-a11c-61de699deea6)
…
This pull request removes 6893 skipped tests and adds 6893 skipped tests. Note that renamed tests count towards both.
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(2416c909-fd3d-48bb-b25a-42d5db2e9244)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(292a95d7-2bb6-43cc-a8b5-6975a2d169b6)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(3200e3ff-e8a1-4053-b997-e9a7a350c6e3)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(32e9a9d4-a7cc-49c6-bc14-377f11a8f4e7)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(51bd2af0-0302-42b6-a613-b25296e069ea)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(53ec5b18-17f6-4eb3-af4f-a5b2e89415fa)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(5896c52e-3591-45f5-b4d8-d94efdc49644)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(740391e1-d783-46d2-9163-b9b596d19359)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(759a8d08-b3fe-40d9-a227-f623d34e440e)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(77ecbe49-887d-4407-9e3f-ca44903df987)
…
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(05e9ca0b-6bcd-4a26-b1c4-e3ef0610b976)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(11125f70-e32c-40cc-a124-8ad3d3a1f1a1)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(23dd2b84-8bb5-4fdd-aa5b-44ef88e6c3be)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(24401fa5-0a15-4d43-acb4-c01dc2e190e2)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(262d977b-c884-457d-b235-0ee2bfe60ed2)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(33ca7a38-799f-4d5b-a296-1129fb29afaf)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(36d97192-5cf6-4d36-b6f5-587ca0a6e7cc)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(5bb77a82-6261-4f62-ba1d-020e222cb934)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(6f842838-9cdd-4397-94e9-708b5d578916)
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests ‑ SetAccessControl_ShouldNotUpdateTimes(746e28dd-4218-4b60-a11c-61de699deea6)
…

@vbreuss
vbreuss merged commit d82c0b0 into main Oct 11, 2026
15 of 16 checks passed
@vbreuss
vbreuss deleted the chore/fix-sonar-issues branch October 11, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants