You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: adopt @tanstack/oracles d1b508a (owns on oracleProperty, no law.owner) - #2407
This pull request adopts @tanstack/oracles and @tanstack/eslint-plugin-oracles at TanStack/oracles d1b508a (TanStack/oracles#11). It is an API migration. It does not change behavior. It prepares the later oracles change that removes legacyCampaigns and declareOracle.
d1b508a makes two changes that affect this repository:
OracleLaw has no owner field. Code ownership belongs to CODEOWNERS (maintainer decision, 2026-11-10). An owner: property in a law literal is now a TypeScript excess-property error.
oracleProperty takes owns, with the same meaning as the owns of declareOracle. The gap CLI reads owns from both calls during the migration.
Changes
Pins. The three pkg.pr.new pins change from b6bf6fc to d1b508a: the root package.json (both packages) and packages/db/package.json. The lockfile changes only in the two tarball URLs and their integrity hashes. The manifests of the new tarballs have the same dependencies, peer dependencies, engines, and bin as the old ones. pnpm install --frozen-lockfile accepts the lockfile, and a later pnpm install reports "Already up to date".
law.owner removed. A TypeScript-AST codemod removed 359 owner properties (one line each) from 190 files:
336 properties in law: { ... } object literals.
23 properties in shared law objects that calls receive through a variable, such as const lifecycleLaw = { statement, authority, limits, owner } with law: lifecycleLaw or { ...pagerLaw, statement }.
No code reads law.owner, and no repository type declares it. Other owner names, such as product fields, variables, and coverage-map prose, are unchanged. The scripts' oracle files are in a separate commit because the first commit missed them.
owns moved to oracleProperty. A TypeScript-AST codemod moved owns in each of the 162 files that have both a declareOracle({ owns }) and at least one inline oracleProperty({ ... }) call:
The owns array goes into each inline oracleProperty call, directly after law. The entries are byte-identical and in the same order. 77 files have one call. 85 files have several calls, and each call gets the same list (390 calls in total). The gap CLI judges ownership per file, so a repeated list has the same meaning.
Two files had two declareOracle calls with owns: live-query-observer-hydration-oracle.property.test.ts and window-render-oracle.test.tsx. Each call gets the ordered union of the lists, without duplicates. In both files, the second list was a subset of the first.
declareOracle keeps its check, model, grammar, typeModel, and other parts, because oracle/no-unit-test reads them. 28 declareOracle calls had only owns. They were removed, and their import was removed in the 26 files that had no other declareOracle use. No oracle/ rule reads owns from declareOracle: no-unit-test collects only identifier parts and typeModel strings.
49 comment blocks moved with the list to the first oracleProperty call. These are a // What this oracle owns: ... comment directly above a declareOracle call, and any comment directly above a removed call. Other comments stay in place.
80 files keep declareOracle({ owns }), because they have no inline oracleProperty call (the list follows). If a file registers through a wrapper in another module, moving its list there would assign the ownership to that other file.
Legacy entries. No change. legacyCampaigns keeps its two entries. See the decisions below.
Docs. The docs did not tell authors to write law.owner or to put owns on declareOracle. They did not describe owns at all. This change adds the guidance:
docs/contributing/oracle-rubric.md: the inline-literal owns form on oracleProperty, the declareOracle fallback, and the rule that a law has no owner field.
docs/contributing/glossary.md: the "oracle owner" row now says that it is not a law field, and a new "owned code" row.
docs/contributing/oracle-coverage.md: the paragraph on the gap report now says where the report reads owns.
AGENTS.md and .agents/skills/oracle-authoring/SKILL.md: one short pointer each.
The coverage map keeps its "owner" column, which is the oracle owner.
No changeset: this change touches only tests, docs, and development dependencies, and the similar pull requests (#2402, #2403, #2406) have none.
Counts
Item
Count
owner: law lines removed
359 (336 inline law: literals, 23 shared law objects), in 190 files
Files whose owns moved to oracleProperty
162 (77 with one call and 85 with several, so 390 calls receive owns)
declareOracle calls removed (only owns remained)
28, with 26 imports removed
Files that keep declareOracle({ owns })
80
(file, owns entry) pairs, before and after
515 in 242 files before, 515 in 242 files after, identical
The task estimate was about 431 owner lines. The AST scan found 359 law owner properties. No owner property is left in a law-shaped object.
Files that keep declareOracle({ owns })
None of these files has an inline oracleProperty({ ... }) call:
67 files register through a production driver, a wrapper in another module (for example, registerIncludesProperty), or it/test over their declared parts.
7 files are end-to-end or Playwright specs.
6 files are companion modules that register no tests.
packages/db/tests/declared-reach-oracle.property.test.ts: kept. This file is the self-oracle for the vendored createOracleReach and runOracleCampaign helpers, and the helpers are its subject. To judge them, it must import them, and oracle/oracle-property-only reports that import. Option (a), conversion, would remove the judgments. Option (b), retirement, does not apply: this migration does not make the helpers unneeded. createOracleReach still has callers outside the legacy list: documented-mutations-support.ts, live-query-bound-options-support.ts, query-db-collection/tests/query.test.ts, electric-db-collection/e2e/collection-gc.e2e.test.ts, and four db-sqlite-persistence-core/tests/sync-metadata-* modules. Only this oracle, legacy-campaign.test.ts, and scripts/oracle-campaign-inventory.mjs use runOracleCampaign. Retiring it alone would leave the entry in place, because of the createOracleReach import. A maintainer decides whether to retire runOracleCampaign and its judgments now.
packages/node-db-sqlite-persistence/tests/expression-index-oracle.test.ts: kept. Its product campaigns already use oracleProperty. The legacy uses are four raw fc.check controls:
the fast-check seed, run, and path configuration self-checks.
the grammar-ablation controls, where each ablated axis must fail with missing=<kind>.
the wrong-answer controls, which must shrink to a non-null counterexamplePath and fail again when the same seed and path replay.
Native oracleProperty calibrations at d1b508a take only a mutant driver or corrupt and a law name. They do not mutate the history arbitrary and do not expose shrink coordinates. d1b508a does not change calibrations. Conversion would therefore drop the shrink-and-replay and ablation judgments. This entry needs a framework calibration that exposes the shrink path and supports grammar ablation.
Verification
Evidence: no behavior changes, the owns pairs are identical, typecheck and lint pass, and the sampled oracles pass.
Owns pairs./tmp scripts read every tracked file that calls oracleProperty or declareOracle. One script uses the gap CLI's own readOwns (oracle-gaps/owners.mjs). It returns 515 (file, entry) pairs in 242 files on both trees, and the sets are identical. A second, independent AST reader compares the raw source text of each entry. It finds the same ordered entry lists per file, and every oracleProperty list in a file equals that file's former list. After the change, 80 files have owns only on declareOracle, 162 files only on oracleProperty, and no file has both.
Gap CLI ownership (static only, no mutation sweep).node node_modules/@tanstack/oracles/oracle-gaps/index.mjs --help works. The CLI has no static-only flag, so the check calls its analyze(), which instruments and reads ownership but runs no tests. It runs on packages/db with --source src/collection/lifecycle.ts:
It reads 122 oracle files and finds 430 mutant sites in 44 functions, with 0 unowned functions and 64 owner files. collection-gc-transaction-oracle.property.test.ts is one of the owners.
The same read on the parent tree (git archive of packages/db before the owns commit) gives an identical owners-by-function map.
Typecheck.tsc --noEmit -p ran in every package with a tsconfig.json (27 packages), after pnpm build:
25 packages have 0 errors.
packages/db and packages/db-collection-e2e each have one TS6059 rootDir error, for scripts/publishable-module-output.mjs from vite.config.ts and for support/test-context.ts. These are configuration errors in files that this branch does not change.
There is no excess-property error for owner or owns.
Lint.pnpm lint:changed passes. pnpm lint:oracles passes: the legacy-campaign gate reports {"added":[]}, and the oracle/ rules pass on every oracle file. The pre-commit hook (the oracle/ rules and eslint --fix) passed on each commit. Prettier reports all changed files as formatted.
Sampled oracles (--maxWorkers=2). Each file runs its declared fixed-seed campaigns and a random campaign:
packages/db/tests/collection-gc-transaction-oracle.property.test.ts (fixed seed 20261024) and packages/db/tests/live-query-observer-hydration-oracle.property.test.ts (20260, -88123, and 2345, the merged-list file): 2 files, 50 tests passed.
packages/db-ivm/tests/multiset-consolidate-oracle.property.test.ts (2026929, where the codemod removed its declareOracle and moved its comment): 41 tests passed.
packages/react-db/tests/window-render-oracle.test.tsx (2291 and 2345, with several nested calls): 480 tests passed.
These are the three packages with the most changed files (db, convex-db-collection, db-ivm), plus react-db.
Scripts oracles.vitest run --config scripts/oracle-scripts.vitest.config.mjs --maxWorkers=2: 9 files and 394 tests pass.
packages/db has no test:oracle-framework script.
Limits
The sample runs 5 of the 162 files whose owns moved. The other files changed only by an inserted owns property and a removed owner property. Typecheck, lint, and the owns comparison cover them.
No gap report or mutation sweep ran. The ownership evidence is static: identical readOwns pairs for every file, and an identical owners map for src/collection/lifecycle.ts.
The two legacyCampaigns entries remain, as described above.
This pull request and its description were written by Isaac.
Summary by CodeRabbit
Documentation
Clarified how oracle checks identify the production code they cover and how ownership is represented in coverage reports.
Added guidance distinguishing code ownership from oracle coverage ownership.
Chores
Updated oracle metadata across test suites to associate checks with the code they assess.
Updated development tooling to a newer package preview.
@tanstack/oracles d1b508a drops `owner` from OracleLaw: code ownership
belongs to CODEOWNERS (maintainer decision, 2026-11-10). Remove the field
from every law literal passed to oracleProperty and from the shared law
objects that those calls receive.
Co-authored-by: Isaac <no-reply@databricks.com>
@tanstack/oracles d1b508a lets oracleProperty take `owns`, with the
meaning that declareOracle's `owns` has. Move each file's owns list into
its inline oracleProperty calls, verbatim and in order. A file with several
calls repeats the list on each call; the gap report judges ownership per
file, so the meaning is the same. A declareOracle call left with no part is
removed with its import. Files that register through a driver or wrapper
and have no inline oracleProperty call keep their declareOracle owns.
The set of (file, owns entry) pairs that the gap report reads is unchanged:
515 pairs in 242 files before and after.
Co-authored-by: Isaac <no-reply@databricks.com>
State where an oracle file names the production code it judges: the
inline `owns` list of each oracleProperty call, in the literal form the
gap report reads statically. A file with no inline oracleProperty call
keeps declareOracle's owns during the migration. A law has no owner
field; code ownership belongs to CODEOWNERS. The coverage map's oracle
owner keeps its meaning.
Co-authored-by: Isaac <no-reply@databricks.com>
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
No actionable comments were generated in the recent review.
Walkthrough
This change updates Oracle documentation and test metadata across the repository. It removes law.owner, moves ownership to per-property owns declarations in many oracle tests, keeps temporary declareOracle({ owns }) guidance for migration cases, and updates Oracle package preview revisions.
The docs now state that oracleProperty calls must declare judged production code in inline owns arrays. They also state that laws do not have an owner field, distinguish oracle ownership from CODEOWNERS ownership, and note that gap reports still read declareOracle({ owns }) when no inline declaration exists. Oracle package preview revisions were updated.
Repository-wide migration to property-level owns packages/.../*oracle*, scripts/*oracle*
Across many oracle test files, ownership metadata moved from law.owner or shared declareOracle({ owns }) declarations to per-property owns declarations on oracleProperty. In many files, standalone declareOracle imports or ownership-only registrations were removed.
Law metadata cleanup where ownership was only descriptive packages/.../*oracle*, scripts/*oracle*
Where a property already had ownership elsewhere or no new owns target was added in the edited block, the change removes the obsolete owner field from law metadata and leaves statements, authorities, limits, models, grammars, and checks unchanged.
TanStack/db#2402 — Both PRs update the Oracle API migration path, documentation, and repository usage of oracleProperty ownership declarations.
Merge Risk: Minimal · up to 6e341
No merge-blocking risk is established from the available evidence.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly identifies the main API migration: adopting the specified oracle package revision, moving owns metadata to oracleProperty, and removing law.owner.
Description check
The description is detailed and relevant. It explains the migration, motivation, ownership changes, verification evidence, test results, known typecheck limits, and the absence of release impact. It d…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description is detailed and relevant. It explains the migration, motivation, ownership changes, verification evidence, test results, known typecheck limits, and the absence of release impact. It does not use the template headings or checklist format exactly, but it provides the required information in equivalent sections.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 64 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Files skipped from review as they are similar to previous changes: 1
docs/contributing/oracle-coverage.md
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Comparing 8e832a3bd (this PR) against a2ba396d5 (base). Write times are per-write medians over 100 iterations (20 warmup writes). Timings use the median of 3 fresh fixture repetition(s).
Overall median write time vs base: 1.01× · cold hydrate time: 1.01× (geometric mean of per-case ratios; lower is faster).
Writes: 1 regression(s), 0 improvement(s) (threshold: ±20% and >0.05ms).
Cold hydrate: No significant changes (threshold: ±50% and >5ms).
CI regression gate: PASS. Query geometric means: >+30% writes or >+50% cold. A case also fails when every repetition exceeds the entire base range by >+50% and the metric's absolute floor.
Per-case flags are noisy on shared runners. Read the geometric means first.
Writes
Query
Δ median write time (geomean)
Best case
Worst case
Flags
list: newest 50 open
+0.4%
-32.3%
+61.4%
—
list + author
-4.9%
-15.1%
-1.1%
—
list + comment count
+5.2%
-1.3%
+18.1%
—
list + 3 recent comments
-0.2%
-17.8%
+10.9%
—
issue detail + comments
+3.9%
-10.5%
+10.9%
—
open issues + documents
+0.9%
-17.8%
+57.0%
1 🔴
Cold hydrate
Query
Δ cold hydrate time (geomean)
Best case
Worst case
Flags
list: newest 50 open
-4.0%
-39.7%
+27.7%
—
list + author
+1.2%
-5.6%
+13.2%
—
list + comment count
+1.2%
-24.0%
+17.1%
—
list + 3 recent comments
+0.5%
-17.8%
+16.7%
—
issue detail + comments
+11.7%
-11.1%
+32.3%
—
open issues + documents
-2.2%
-37.0%
+31.3%
—
Each row aggregates that query's scale/index/write-mode configurations; per-configuration tables below.
Runner: node v24.8.0, linux 7.0.0-1017-azure, AMD EPYC 9V74 80-Core Processor. Timings on shared CI runners are noisy; treat small deltas as indicative only.
Takes main's rewrites of the eager live-source conformance oracles and the
TrailBase lifecycle oracle, then reapplies this branch's codemods to the
merged tree: 46 law.owner properties removed in 21 files, and owns moved into
oracleProperty in 14 more files. The (file, owns entry) pairs equal main's:
537 pairs, identical.
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adopts
@tanstack/oraclesand@tanstack/eslint-plugin-oraclesat TanStack/oraclesd1b508a(TanStack/oracles#11). It is an API migration. It does not change behavior. It prepares the later oracles change that removeslegacyCampaignsanddeclareOracle.d1b508amakes two changes that affect this repository:OracleLawhas noownerfield. Code ownership belongs to CODEOWNERS (maintainer decision, 2026-11-10). Anowner:property in a law literal is now a TypeScript excess-property error.oraclePropertytakesowns, with the same meaning as theownsofdeclareOracle. The gap CLI readsownsfrom both calls during the migration.Changes
Pins. The three
pkg.pr.newpins change fromb6bf6fctod1b508a: the rootpackage.json(both packages) andpackages/db/package.json. The lockfile changes only in the two tarball URLs and their integrity hashes. The manifests of the new tarballs have the same dependencies, peer dependencies, engines, and bin as the old ones.pnpm install --frozen-lockfileaccepts the lockfile, and a laterpnpm installreports "Already up to date".law.ownerremoved. A TypeScript-AST codemod removed 359ownerproperties (one line each) from 190 files:law: { ... }object literals.const lifecycleLaw = { statement, authority, limits, owner }withlaw: lifecycleLawor{ ...pagerLaw, statement }.No code reads
law.owner, and no repository type declares it. Otherownernames, such as product fields, variables, and coverage-map prose, are unchanged. The scripts' oracle files are in a separate commit because the first commit missed them.ownsmoved tooracleProperty. A TypeScript-AST codemod movedownsin each of the 162 files that have both adeclareOracle({ owns })and at least one inlineoracleProperty({ ... })call:ownsarray goes into each inlineoraclePropertycall, directly afterlaw. The entries are byte-identical and in the same order. 77 files have one call. 85 files have several calls, and each call gets the same list (390 calls in total). The gap CLI judges ownership per file, so a repeated list has the same meaning.declareOraclecalls withowns:live-query-observer-hydration-oracle.property.test.tsandwindow-render-oracle.test.tsx. Each call gets the ordered union of the lists, without duplicates. In both files, the second list was a subset of the first.declareOraclekeeps itscheck,model,grammar,typeModel, and other parts, becauseoracle/no-unit-testreads them. 28declareOraclecalls had onlyowns. They were removed, and their import was removed in the 26 files that had no otherdeclareOracleuse. Nooracle/rule readsownsfromdeclareOracle:no-unit-testcollects only identifier parts andtypeModelstrings.oraclePropertycall. These are a// What this oracle owns: ...comment directly above adeclareOraclecall, and any comment directly above a removed call. Other comments stay in place.declareOracle({ owns }), because they have no inlineoraclePropertycall (the list follows). If a file registers through a wrapper in another module, moving its list there would assign the ownership to that other file.Legacy entries. No change.
legacyCampaignskeeps its two entries. See the decisions below.Docs. The docs did not tell authors to write
law.owneror to putownsondeclareOracle. They did not describeownsat all. This change adds the guidance:docs/contributing/oracle-rubric.md: the inline-literalownsform onoracleProperty, thedeclareOraclefallback, and the rule that a law has no owner field.docs/contributing/glossary.md: the "oracle owner" row now says that it is not a law field, and a new "owned code" row.docs/contributing/oracle-coverage.md: the paragraph on the gap report now says where the report readsowns.AGENTS.mdand.agents/skills/oracle-authoring/SKILL.md: one short pointer each.The coverage map keeps its "owner" column, which is the oracle owner.
No changeset: this change touches only tests, docs, and development dependencies, and the similar pull requests (#2402, #2403, #2406) have none.
Counts
owner:law lines removedlaw:literals, 23 shared law objects), in 190 filesownsmoved tooraclePropertyowns)declareOraclecalls removed (onlyownsremained)declareOracle({ owns })The task estimate was about 431
ownerlines. The AST scan found 359 lawownerproperties. Noownerproperty is left in a law-shaped object.Files that keep
declareOracle({ owns })None of these files has an inline
oracleProperty({ ... })call:registerIncludesProperty), orit/testover their declared parts.The 80 files
e2e or Playwright spec
packages/browser-db-sqlite-persistence/e2e/electric-source-prefix-oracle.opfs.spec.tspackages/browser-db-sqlite-persistence/e2e/leader-close-oracle.opfs.spec.tspackages/browser-db-sqlite-persistence/e2e/opfs-open-outcome-oracle.e2e.test.tspackages/browser-db-sqlite-persistence/e2e/opfs-request-order-oracle.opfs.spec.tspackages/browser-db-sqlite-persistence/e2e/reload-class-oracle.opfs.spec.tspackages/browser-db-sqlite-persistence/e2e/shared-driver-fairness-oracle.opfs.spec.tspackages/electron-db-sqlite-persistence/tests/reload-class-oracle.electron.e2e.test.tsregisters through a driver, wrapper, or ordinary it/test
packages/browser-db-sqlite-persistence/tests/multi-tab-electric-oracle.test.tspackages/browser-db-sqlite-persistence/tests/opfs-open-outcome-oracle.test.tspackages/browser-db-sqlite-persistence/tests/per-collection-coordinator-oracle.test.tspackages/browser-db-sqlite-persistence/tests/shared-driver-fairness-oracle.test.tspackages/db-ivm/tests/temporal-group-key-oracle.test.tspackages/db-sqlite-persistence-core/tests/persisted-demand-coverage-oracle.test.tspackages/db-sqlite-persistence-core/tests/sqlite-temporal-value-oracle.test.tspackages/db/tests/collection-cleanup-restart-oracle.test.tspackages/db/tests/collection-index-value-oracle.test.tspackages/db/tests/collection-row-metadata-composition-oracle.test.tspackages/db/tests/collection-subscription-reentrancy-oracle.test.tspackages/db/tests/conformance/indexing-reuse-oracle.test.tspackages/db/tests/db-client-hydration-authority-oracle.test.tspackages/db/tests/duration-query-equality-oracle.test.tspackages/db/tests/effect-disposal-oracle.test.tspackages/db/tests/index-suggestion-oracle.test.tspackages/db/tests/indexed-db/cross-tab-boundary-oracle.test.tspackages/db/tests/indexed-db/local-write-order-oracle.test.tspackages/db/tests/indexed-db/pending-history-oracle.test.tspackages/db/tests/indexed-db/persistence-values-oracle.test.tspackages/db/tests/indexed-db/retirement-oracle.test.tspackages/db/tests/indexed-db/transport-oracle.test.tspackages/db/tests/indexed-db/wrapper-settlement-oracle.test.tspackages/db/tests/local-only-direct-write-oracle.test.tspackages/db/tests/local-storage-order-oracle.test.tspackages/db/tests/optimistic-composition-oracle.test.tspackages/db/tests/optimistic-history-publication-oracle.test.tspackages/db/tests/paced-mutations-oracle.test.tspackages/db/tests/production-error-messages-oracle.test.tspackages/db/tests/proxy-iteration-contract-oracle.test.tspackages/db/tests/query/includes-alias-shadowing-oracle.test.tspackages/db/tests/query/includes-collection-oracle.property.test.tspackages/db/tests/query/includes-context-transport-oracle.test.tspackages/db/tests/query/includes-cross-formulation-oracle.property.test.tspackages/db/tests/query/includes-functional-projection-oracle.test.tspackages/db/tests/query/includes-optimistic-oracle.property.test.tspackages/db/tests/query/includes-oracle.property.test.tspackages/db/tests/query/includes-outer-join-route-work-oracle.test.tspackages/db/tests/query/includes-publication-oracle.test.tspackages/db/tests/query/includes-query-shape-oracle.test.tspackages/db/tests/query/includes-space-oracle.test.tspackages/db/tests/query/includes-temporal-oracle.test.tspackages/db/tests/query/includes-work-counter-oracle.test.tspackages/db/tests/query/index-path-collision-oracle.test.tspackages/db/tests/query/load-subset-source-readiness-refinement-oracle.test.tspackages/db/tests/query/load-subset-transaction-refinement-oracle.test.tspackages/db/tests/query/mixed-index-order-oracle.test.tspackages/db/tests/query/optimizer-semantics-oracle.test.tspackages/db/tests/query/ordered-source-loader-oracle.test.tspackages/db/tests/query/subquery-user-value-oracle.test.tspackages/db/tests/query/virtual-row-fields-effect-oracle.test.tspackages/db/tests/query/virtual-row-fields-input-oracle.test.tspackages/db/tests/query/virtual-row-fields-oracle.test.tspackages/db/tests/query/virtual-row-fields-types-oracle.test.tspackages/db/tests/truncate-readiness-oracle.test.tspackages/electric-db-collection/tests/pg-serializer-oracle.property.test.tspackages/electron-db-sqlite-persistence/tests/electron-ipc-readiness-oracle.test.tspackages/offline-transactions/tests/connectivity-replay-oracle.test.tspackages/query-db-collection/tests/includes-work-counter-oracle.test.tspackages/query-db-collection/tests/ownership-lifecycle.oracle.test.tspackages/query-db-collection/tests/persisted-direct-write-window.oracle.test.tspackages/query-db-collection/tests/ssr-dehydration-oracle.test.tspackages/react-db/tests/convex-lazy-paging-oracle.test.tsxpackages/react-db/tests/effect-callback-oracle.test.tsxpackages/react-db/tests/infinite-query-render-cuts-oracle.test.tsxpackages/react-db/tests/usePacedMutations-render-cuts-oracle.test.tsxpackages/vue-db/tests/useLiveQuery-publication-oracle.test.tscompanion module (no test registration)
packages/db/tests/collection-metadata-publication-oracle.tspackages/db/tests/comparison-laws-oracle.tspackages/electric-db-collection/tests/documented-mutations-oracle.test.tspackages/offline-transactions/tests/executor-environment-oracle.property.test.tspackages/offline-transactions/tests/transaction-serializer-oracle.tspackages/query-db-collection/tests/documented-mutations-oracle.test.tsLegacy-entry decisions
packages/db/tests/declared-reach-oracle.property.test.ts: kept. This file is the self-oracle for the vendoredcreateOracleReachandrunOracleCampaignhelpers, and the helpers are its subject. To judge them, it must import them, andoracle/oracle-property-onlyreports that import. Option (a), conversion, would remove the judgments. Option (b), retirement, does not apply: this migration does not make the helpers unneeded.createOracleReachstill has callers outside the legacy list:documented-mutations-support.ts,live-query-bound-options-support.ts,query-db-collection/tests/query.test.ts,electric-db-collection/e2e/collection-gc.e2e.test.ts, and fourdb-sqlite-persistence-core/tests/sync-metadata-*modules. Only this oracle,legacy-campaign.test.ts, andscripts/oracle-campaign-inventory.mjsuserunOracleCampaign. Retiring it alone would leave the entry in place, because of thecreateOracleReachimport. A maintainer decides whether to retirerunOracleCampaignand its judgments now.packages/node-db-sqlite-persistence/tests/expression-index-oracle.test.ts: kept. Its product campaigns already useoracleProperty. The legacy uses are four rawfc.checkcontrols:missing=<kind>.counterexamplePathand fail again when the same seed and path replay.Native
oraclePropertycalibrations atd1b508atake only a mutantdriverorcorruptand a law name. They do not mutate the history arbitrary and do not expose shrink coordinates.d1b508adoes not change calibrations. Conversion would therefore drop the shrink-and-replay and ablation judgments. This entry needs a framework calibration that exposes the shrink path and supports grammar ablation.Verification
Evidence: no behavior changes, the owns pairs are identical, typecheck and lint pass, and the sampled oracles pass.
Owns pairs.
/tmpscripts read every tracked file that callsoraclePropertyordeclareOracle. One script uses the gap CLI's ownreadOwns(oracle-gaps/owners.mjs). It returns 515 (file, entry) pairs in 242 files on both trees, and the sets are identical. A second, independent AST reader compares the raw source text of each entry. It finds the same ordered entry lists per file, and everyoraclePropertylist in a file equals that file's former list. After the change, 80 files haveownsonly ondeclareOracle, 162 files only onoracleProperty, and no file has both.Gap CLI ownership (static only, no mutation sweep).
node node_modules/@tanstack/oracles/oracle-gaps/index.mjs --helpworks. The CLI has no static-only flag, so the check calls itsanalyze(), which instruments and reads ownership but runs no tests. It runs onpackages/dbwith--source src/collection/lifecycle.ts:collection-gc-transaction-oracle.property.test.tsis one of the owners.git archiveofpackages/dbbefore theownscommit) gives an identical owners-by-function map.Typecheck.
tsc --noEmit -pran in every package with atsconfig.json(27 packages), afterpnpm build:packages/dbandpackages/db-collection-e2eeach have one TS6059rootDirerror, forscripts/publishable-module-output.mjsfromvite.config.tsand forsupport/test-context.ts. These are configuration errors in files that this branch does not change.ownerorowns.Lint.
pnpm lint:changedpasses.pnpm lint:oraclespasses: the legacy-campaign gate reports{"added":[]}, and theoracle/rules pass on every oracle file. The pre-commit hook (theoracle/rules andeslint --fix) passed on each commit. Prettier reports all changed files as formatted.Sampled oracles (
--maxWorkers=2). Each file runs its declared fixed-seed campaigns and a random campaign:packages/db/tests/collection-gc-transaction-oracle.property.test.ts(fixed seed 20261024) andpackages/db/tests/live-query-observer-hydration-oracle.property.test.ts(20260, -88123, and 2345, the merged-list file): 2 files, 50 tests passed.packages/convex-db-collection/tests/offline-oracle.property.test.ts(20261022, 20261023): 9 tests passed.packages/db-ivm/tests/multiset-consolidate-oracle.property.test.ts(2026929, where the codemod removed itsdeclareOracleand moved its comment): 41 tests passed.packages/react-db/tests/window-render-oracle.test.tsx(2291 and 2345, with several nested calls): 480 tests passed.These are the three packages with the most changed files (db, convex-db-collection, db-ivm), plus react-db.
Scripts oracles.
vitest run --config scripts/oracle-scripts.vitest.config.mjs --maxWorkers=2: 9 files and 394 tests pass.packages/dbhas notest:oracle-frameworkscript.Limits
ownsmoved. The other files changed only by an insertedownsproperty and a removedownerproperty. Typecheck, lint, and theownscomparison cover them.readOwnspairs for every file, and an identical owners map forsrc/collection/lifecycle.ts.legacyCampaignsentries remain, as described above.This pull request and its description were written by Isaac.
Summary by CodeRabbit