Skip to content

fix(create): only pack dist - #515

Merged
tannerlinsley merged 2 commits into
TanStack:mainfrom
43081j:jg/pack-less
Nov 1, 2026
Merged

tannerlinsley merged 2 commits into
TanStack:mainfrom
43081j:jg/pack-less

Conversation

@43081j

@43081j 43081j commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

We currently pack sources, tests, etc, since files is not specified.

This sets it to the same as the CLI (minus the skills/ as create has
none).

Summary by CodeRabbit

  • Chores
    • Published releases of the create package now contain the distributable build and package metadata, while excluding source files and tests. The installed package therefore includes fewer files beyond what is needed to use the published build. This change affects the contents of the published package; it does not add or remove any public functionality.

AI review notes:
Updated against current main and added a patch changeset. The actual packed candidate keeps all 784 built files byte-for-byte, including every declared export and both frameworks’ assets. Its compressed archive falls from 39,069,215 to 19,598,324 bytes, with no runtime file changes.
Installed the packed engine with published CLI 0.72.2 outside this monorepo. The five concrete runtime entry points import successfully. React/npm with T3Env and Solid/pnpm both generate, install, build, type-check, render SSR and navigate in Chromium without replacing the document after client readiness. This uses the candidate archive, not a newly published package.
The normal pre-commit build, unit and seven blocking e2e gates passed. Other package-manager combinations were not separately installed for this packaging-only change.

We currently pack sources, tests, etc, since `files` is not specified.

This sets it to the same as the CLI (minus the `skills/` as create has
none).
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 845d77d1-682a-4c14-802c-3d7185c24e3d
Commits

Reviewing files that changed from the base of the PR and between a6130bb and 0783b03.

Files selected for processing: 1
  • .changeset/pack-dist-only.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The @tanstack/create package manifest now lists dist in its files array. A patch changeset records that published packages include built files and package metadata, but exclude sources and tests.

Changes: Package publishing

Layer / File(s) Summary
Published file selection
packages/create/package.json, .changeset/pack-dist-only.md
The manifest lists dist in the files array. The changeset records the publishing change.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to 0783b

The package restriction preserves the required runtime files and metadata, with no confirmed merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title "fix(create): only pack dist" matches the main change. The PR adds a files array to packages/create/package.json that lists only dist, so npm publishes only built files and package met…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "fix(create): only pack dist" matches the main change. The PR adds a files array to packages/create/package.json that lists only dist, so npm publishes only built files and package metadata. The changeset also describes this patch release. The title is short, specific, and names the affected package.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0783b03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@tanstack/create Patch
create-start-app Patch
create-tanstack-app Patch
create-tanstack Patch
create-tsrouter-app Patch
@tanstack/create-start Patch
@tanstack/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tannerlinsley
tannerlinsley merged commit 46ea770 into TanStack:main Nov 1, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 1, 2026
@43081j
43081j deleted the jg/pack-less branch November 2, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants