Repository navigation
Add alternative alignment for CDS - #178
Merged
Merged
Conversation
jakebeal
approved these changes
Oct 15, 2026
cjmyers
approved these changes
Oct 15, 2026
Contributor
|
While I approved this, the builds are failing. Looks like something needs to be updated. Please sort this before merging this PR. |
Contributor
Author
|
@cjmyers Should I add changes to address the Github actions on this PR or make a new one? |
Contributor
|
I think it is fine to fix this PR |
Contributor
|
Passing now. Should be safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #177 we'd like to add an explicit accepted alternate alignment for the CDS glyph (and thus compliant with best practices).
Feel free to propose different wording since I know the controlled vocabulary is quite important for the spec