Repository navigation
[BootstrapAdminUi] Fix ghost secondary buttons hover in dark mode - #406
Merged
Merged
Conversation
loic425
approved these changes
Nov 12, 2026
TheMilek
added a commit
to Sylius/Sylius
that referenced
this pull request
Nov 12, 2026
| Q | A |-----------------|----- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | same fix as Sylius/Stack#406 | License | MIT ## Description In dark mode, hovering a `.btn-ghost-secondary` turns it into a light grey pill with a near-white icon, which makes the icon disappear. It affects the theme switcher and the pagination dropdown toggle. Tabler resolves `--tblr-secondary-fg` at build time from the light theme `$secondary`, then remaps `--tblr-secondary` to a light grey in dark mode without recomputing it. The hover now uses `--tblr-active-bg` instead, the same surface as `.btn-action:hover`, so the button stays a ghost. Contrast on hover goes from 1.43:1 to 8.97:1 in dark mode, and from 1.99:1 to 14.86:1 in light mode. Nothing changes at rest. | Dark | Light | |------|-------| | <img width="400" alt="Ghost secondary button states in dark mode" src="https://github.com/user-attachments/assets/5c05139d-98c6-4a44-afcf-28be336f1b3d" /> | <img width="400" alt="Ghost secondary button states in light mode" src="https://github.com/user-attachments/assets/b5775700-2b16-48d2-9cae-bb82268ca1b1" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dark mode, hovering a
.btn-ghost-secondaryturns it into a light grey pill with a near-white icon, which makes the icon disappear. It affects the theme switcher, the pagination dropdown toggle and the copy-to-clipboard buttons.Tabler resolves
--tblr-secondary-fgat build time from the light theme$secondary, then remaps--tblr-secondaryto a light grey in dark mode without recomputing it. The hover now uses--tblr-active-bginstead, the same surface as.btn-action:hover, so the button stays a ghost.Contrast on hover goes from 1.43:1 to 8.97:1 in dark mode, and from 1.99:1 to 14.22:1 in light mode. Nothing changes at rest.
public/assets were rebuilt withyarn build.