Repository navigation
[BootstrapAdminUi] Backport generic admin CSS fixes from Sylius - #404
Merged
loic425 merged 2 commits intoNov 12, 2026
Merged
Conversation
- Dark mode: configurable background variables, readable ghost and secondary buttons, keep validation and focus borders on form controls, invert empty state images - Tom-select: theme multi-select items and remove buttons in dark mode - Breadcrumb: link color in both themes and ellipsis on long items - Forms: 44px touch area for file input buttons - Fonts: load InterVariable as woff2 with a sans-serif fallback - Modal: darker backdrop
loic425
marked this pull request as ready for review
November 10, 2026 16:44
camilleislasse
approved these changes
Nov 11, 2026
Contributor
There was a problem hiding this comment.
Redundant !important, the tom-select rule it overrides has the same specificity and comes first, so this already wins
Contributor
There was a problem hiding this comment.
Same here. Tested without both, no visual change.
Member
Author
|
@camilleislasse Thx so much for your review, much appreciated. |
loic425
added a commit
that referenced
this pull request
Nov 12, 2026
| Q | A |-----------------|----- | Branch? | main | Bug fix? | yes | New feature? | no | BC breaks? | no | License | MIT Follow-up of #404. The sidebar submenu items look more spaced out than in the Sylius admin. Sylius removed `min-height: 44px` from `.navbar-collapse a.nav-link` / `a.dropdown-item` in Sylius/Sylius@7b2d5a77e7 ("Remove additional spacings in admin sidebar menu"), but the rule was kept in BootstrapAdminUi. - Submenu items (`.dropdown-item`) go from 44px to 30px, same as in the Sylius admin. - Top-level items are unchanged (Tabler already sets a 40px min-height on them). `public/` assets were rebuilt with `yarn build`. | Before | After | |--------|-------| | <img width="400" alt="Sidebar menu before" src="https://github.com/user-attachments/assets/1596a225-fd07-40ed-8a9d-9fb6f6e98338" /> | <img width="400" alt="Sidebar menu after" src="https://github.com/user-attachments/assets/419b55ad-e374-4669-b633-101f9422d24f" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several generic fixes landed in the Sylius admin stylesheets (mostly the dark mode batch) and were never ported to BootstrapAdminUi. This PR backports the ones that are not e-commerce specific.
$dark-body-bg/$dark-bg-surfacevariables, ghost/secondary buttons stay readable, form controls keep theiris-invalid/is-valid/ focus borders, empty state images are inverted.sans-seriffallback (wasserif).Example: an invalid field in dark mode used to lose its red border because the neutral border override had higher priority; it now uses
:where(:not(.is-invalid):not(.is-valid):not(:focus)).Not included (follow-ups): RTL stylesheet (needs a
dirattribute in the layout), sticky page header (needs JS), logo color viacurrentColor(needs template changes).public/assets were rebuilt withyarn build.