Repository navigation
ReviewSLA: don't re-request a review from a new assignee who already approved - #51
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
willson556
marked this pull request as ready for review
October 15, 2026 18:49
staflsystemsci
Bot
requested review from
a team,
fcheein,
gretl-silva-stafl,
mament0,
mns4595,
mzhu48,
nehalkpatel and
thebhef
and removed request for
a team
October 15, 2026 18:49
mns4595
approved these changes
Oct 15, 2026
nehalkpatel
approved these changes
Oct 15, 2026
Member
Author
Merge activity
|
willson556
changed the base branch from
review-sla-standing-approval
to
graphite-base/51
October 15, 2026 20:19
…approved On an out-of-office reassignment, the new assignee was requested as a reviewer on every PR they took over, including ones they had already approved. On StaflLib#2393 that asked willson556 to review again 22 minutes after his approval. Skip the request where their approval stands; they're still made assignee. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
willson556
force-pushed
the
review-sla-no-rerequest
branch
from
October 15, 2026 20:19
18660bf to
d21e267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ReviewSLA hands an out-of-office assignee's reviews to someone else, it also requests a review from the new assignee on every PR they take over, even ones they've already approved. On StaflSystems/StaflLib#2393, willson556 approved at 18:18. At 18:40 he replaced thebhef as assignee and got a fresh review request, and he approved again at 18:48.
Fix:
reassign()still makes them assignee, but only requests their review on PRs where they don't already have a standing approval.Tests: 1 new test in
run.test.js: the new assignee had already approved the bottom PR of a two-PR stack, so only the top PR gets a request. It fails on the old code.node --testpasses all 110 tests.Stacked on #50, which adds the standing-approval rules this relies on.
🤖 Generated with Claude Code