Repository navigation
Support python 3.14 - #4173
Support python 3.14#4173
Conversation
|
From trying locally on macOS: I had to pin |
|
Numba 0.63, which supports 3.14, is out! |
|
There is some dependency resolution thing remaining, I will take a look. |
|
Failures were different for all three systems (oi oi oi). Working fine for me locally (mac) with same version of numcodecs as was failing on the ci. Trying to run again... still not working. Hmmm. |
|
Ok, this is another bullet in the same direction. I investigated and to get this through we need to add zarr 3.0 support : / |
|
Depends on #4260 |
# Conflicts: # .github/workflows/all-tests.yml # pyproject.toml
…g a clear error on zarr writes
|
@alejoe91 @chrishalcrow I took another look at this today. Back in January I concluded that Python 3.14 needed zarr 3, so this PR has been waiting on #4260. As we are doing a patch release, I would like to unblock Python 3.14 for NeuroConv with it. So I want to propose splitting this instead: unblock Python 3.14 now for everything except writing to zarr, and add zarr writing when #4260 is out. The reason this is cheap is that the zarr 2 stack is barely installable on 3.14 anyway. What the PR does now:
I also merged Would this work for you? @alejoe91 is it OK to land this before #4260? Then #4260 would only need to drop the version markers and the skips. The latter should be easy cake for an agent and this will unblock python 3.14 on neuroconv. |
| from spikeinterface.core.core_tools import is_zarr_write_supported | ||
|
|
||
| # TODO: remove once writing to zarr is supported with zarr>=3 | ||
| requires_zarr_write = pytest.mark.skipif( |
There was a problem hiding this comment.
could we move this to conftest.py so we don't need to repeat it (and then remove it!) everywhere?
|
@h-mayorquin I think we have to skip the zarr streaming and ibl streaming too (or maybe just not install the ibl libraries for 3.14). Also added a small comment about centralizing the |
…rr streaming tests on Python 3.14
…n save_array is set
|
@alejoe91 the checks are green on the last commit. I did what you asked. The IBL failure is not Python 3.14 itself. CI found a few more things that needed a skip or a clear error:
Once this lands, #4260 (Support zarr v3) only needs to drop the version markers and the |
|
Thanks @h-mayorquin Looks good to me then! |
No description provided.