Skip to content

fix: serialize panel curation changes on the event loop - #285

Merged
chrishalcrow merged 2 commits into
SpikeInterface:mainfrom
alejoe91:fix-panel-labels-multi-thread
Oct 7, 2026
Merged

chrishalcrow merged 2 commits into
SpikeInterface:mainfrom
alejoe91:fix-panel-labels-multi-thread

Conversation

@alejoe91

Copy link
Copy Markdown
Member

With pn.config.nthreads>1, client events are handled concurrently on the thread pool, so label edits/shortcuts could read stale table state and race with "Save curation", silently dropping labels.

This PR schedule curation changes (labels, delete/merge, restore, save, external curation) on the event loop, and run the heavy visibility update on the pool afterwards.

@chrishalcrow chrishalcrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All panel backend stuff. Tested and works locally.

@chrishalcrow
chrishalcrow merged commit c36782d into SpikeInterface:main Oct 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants