Repository navigation
perf: avoid duplication of PCA array with reshape - #283
Merged
Merged
Conversation
chrishalcrow
reviewed
Oct 7, 2026
chrishalcrow
reviewed
Oct 7, 2026
chrishalcrow
approved these changes
Oct 7, 2026
chrishalcrow
left a comment
chrishalcrow
left a comment
Member
There was a problem hiding this comment.
Makes sense, looks good on tests and on local data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
self.pc_data.swapaxes(1,2).reshape(self.pc_data.shape[0], -1)was essentialy duplicating the full PCA buffer in memory, which can be very large already.This PR modifies the construction of the
controller._pc_projectionsso that reshaping ends up being a view.