Repository navigation
Use server-provided scan report links - #399
Open
John-David Dalton (jdalton) wants to merge 2 commits into
Open
John-David Dalton (jdalton) wants to merge 2 commits into
John-David Dalton (jdalton) wants to merge 2 commits into
Conversation
John-David Dalton (jdalton)
force-pushed
the
fix/python-server-report-urls
branch
from
October 13, 2026 16:35
85170a0 to
b8b6d48
Compare
John-David Dalton (jdalton)
force-pushed
the
fix/python-server-report-urls
branch
from
October 13, 2026 16:49
b8b6d48 to
d3b0c22
Compare
This was referenced Oct 13, 2026
The test checks that explicit files skip a second discovery walk. It failed only because its stub full scan had no html_report_url, which create_full_scan_with_report_url now reads.
Contributor
|
If the diff-scan response has no Is |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python CLI output now uses Socket’s report links, so comparisons and scans point to the server’s intended pages, including alternate deployments.
The CLI preserves query parameters and fragments, matches nested scan IDs before attaching links, and omits unavailable Jira and Slack links.
Builds on #398. Validation: 36 focused tests and scoped Ruff pass. The streaming SDK does not return old/new scan URLs, so only known scan-creation links are retained.
Use server-provided report links and preserve their query parameters in Python CLI output.