Repository navigation
Compile tests on Windows in the merge queue - #1378
Merged
Merged
Conversation
Lean scope skips every Windows leg on pull requests and in the merge queue, so a cfg(unix) slip in a test reaches main and is caught only by the nightly. #1324 did exactly that: a new test separated covgap_commands_vendor's symlink test from its #[cfg(unix)] gate, and only the full-scope e2e-build-windows run caught the compile error. e2e-build-windows now also runs on merge_group. That is one GitHub-hosted Windows job per queue group that compiles every test target. Its consumers (e2e-windows, cargo-vex-matrix-windows) stay full-scope only, so no Windows tests run in the queue. The reused push on main still skips it as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Mikola Lysenko (mikolalysenko)
added
the
ci-perf
Mikola Lysenko (mikolalysenko)
requested review from
Tanmay Singla (Tanmay182003) and
Wenxin Jiang (Wenxin-Jiang)
October 10, 2026 09:29
Mikola Lysenko (mikolalysenko)
enabled auto-merge
October 10, 2026 09:29
Tanmay Singla (Tanmay182003)
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lean CI (#1375) skips every Windows leg on PRs and in the merge queue, so a
cfg(unix)slip in a test only surfaces in the nightly. #1324 did exactly that: a new test separatedcovgap_commands_vendor's symlink test from its#[cfg(unix)]gate (could not find unix in os), and only a full-scopee2e-build-windowsrun caught it.Change
e2e-build-windowsnow also runs onmerge_group. That's one GitHub-hosted Windows job per queue group that compiles every test target, compared with the ~40 Windows/macOS jobs the pre-lean gate ran.e2e-windows,cargo-vex-matrix-windows) keep their own full-scope gates, so no Windows tests run in the queue, only the compile.Verification
python3 -m unittest discover -s scripts/tests: OK.🤖 Generated with Claude Code
Note
Low Risk
CI workflow
ifconditions and comments only; no application or release logic changes.Overview
Lean CI skipped all Windows jobs in the merge queue, so Windows-only compile failures (e.g. a test missing
#[cfg(unix)]) could reach main until nightly.e2e-build-windowsnow runs whengithub.event_name == 'merge_group', not only underCI_SCOPE=full, schedule, or dispatch. That adds one Windows job per queue entry that compiles every CLI test target—without running the full Windows e2e matrix.e2e-windowsandcargo-vex-matrix-windowskeep their existing full-scope gates, so merge-queue Windows coverage stays compile-only. PR lean runs are unchanged (still no Windows).Workflow comments at the top of
ci.ymldocument the exception to the lean Windows/macOS skip.Reviewed by Cursor Bugbot for commit b6a95ce. Configure here.