Skip to content

fix(wrapper): correct disable guidance - #1608

Open
John-David Dalton (jdalton) wants to merge 1 commit into
mainfrom
fix/wrapper-off-guidance-main
Open

John-David Dalton (jdalton) wants to merge 1 commit into
mainfrom
fix/wrapper-off-guidance-main

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

LLM Description written by Codex:GPT-6

Users can disable the shell wrapper with the supported socket wrapper off command shown in the success output.

A real CLI process test uses a temporary home, config directory, and shell profile. It verifies that on adds the aliases and off removes them.

Validation:

  • pnpm run build:cli passed.
  • pnpm run test:integration test/integration/cli/cmd-wrapper.test.mts passed (4 tests).
  • pnpm run type:cli passed.
  • Scoped lint passed.

Note

Low Risk
User-facing copy fix and test coverage only; no change to wrapper enable/disable behavior beyond messaging.

Overview
Updates the post-enable success message so users are told to run socket wrapper off instead of the unsupported socket wrapper --disable, matching the documented on / off subcommands.

Adds an integration test that runs wrapper on and wrapper off against a temporary home and shell profile: it asserts the CLI output shows the correct disable command, and that npm / npx aliases are written to the profile on enable and removed on disable.

Reviewed by Cursor Bugbot for commit 1d6acaa. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but none of the reported issues met your autofix severity threshold.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1d6acaa. Configure here.

Comment thread src/command/wrapper/socket-wrapper-addition.mts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant