fix(firewall): pin sfw v1.15.3 - #19
Merged
Merged
Conversation
Julian Gruber (juliangruber)
force-pushed
the
fix/bump-sfw-1.15.3
branch
from
September 29, 2026 13:04
96ef2c9 to
00529a7
Compare
sfw v1.15.3 carries two fixes for failures seen on Windows CI runners: the libuv exit assertion in Node 24 SEA binaries (SocketDev/firewall#203) and a failed telemetry send taking the wrapped package manager down with it (SocketDev/firewall#202). The action installs only the version its checksum table covers, so until this bump neither fix is installable through it. Recompute all twelve checksums from the published v1.15.3 assets and rebuild dist/.
Julian Gruber (juliangruber)
force-pushed
the
fix/bump-sfw-1.15.3
branch
from
September 30, 2026 10:14
00529a7 to
922cc1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sfw v1.15.3 shipped with two fixes for failures seen on Windows CI runners:
Assertion failed: !(handle->flags & UV_HANDLE_CLOSING).The action only installs the version its checksum table covers, so v1.15.3 is not installable through it until the pin moves.
What
FIREWALL_VERSION→v1.15.3firewall-releaseandsfw-free(downloaded viagh release download, hashed withshasum -a 256).dist/main.jsrebuilt.dist/post.jsis unchanged.Verification
test/unit/tools/firewall.test.mtspasses.dist/is byte-identical to the committed one when built from unmodifiedmainwith the same toolchain, so the onlydist/change is this pin.Note on local tooling
pnpm run build,pnpm testand the pre-push type check cannot pass from a fresh clone right now: the committedscripts/repo/build.mtsimportsscripts/fleet/process/run-main.mts, which the current fleet pack (d60c6f3) does not ship.dist/was bundled by driving rolldown with the repo's own.config/repo/rolldown.config.mts, and the push used--no-verifybecause the type errors are all in fleet files this PR does not touch. A separate re-cascade PR addresses that.Stacking
#18 (mirror origin) is based on
mainand will need a rebase onto this once merged: its checksum table and test fixtures still reference v1.15.2.🤖 Generated with Claude Code