Repository navigation
Conversation
…er places that wanted loaded Scripts, not Files
skriptlang-automation
Bot
added
the
needs triage
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
bug
…(it was technically unknowable)
…places ValidationResult, too specific)
Member
Author
|
alright time to go through and fix all the ai design mistakes now |
…ix spreading with different types a rather messy commit, will need cleaning up
I'm a bit sus of this change but i'll go back through it when i fix up the pr as a whole
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dynamic functions have very limited argument resolution, no feedback on errors, don't support overloading, and struggle to verify arguments. They do not use the new function API and rely on deprecated api from before 2.14.
Solution
Significant rework to Executable and DynamicFunctionReference, introducing argument binding, spreading when given a single list, parse and runtime errors when binding fails, and general improvements. I will fill this section out more later.
Testing Completed
Many new tests added
Supporting Information
Completes: none
Related: none
AI assistance: Claude code was the primary driver of this change so far, doing the vast majority of the work and planning, only guided by my comments. I have not yet fully reviewed this code and as such have marked it as draft. I will be going through, verifying, possibly rewriting some things, and ensuring it's not all nonsense. The code I have reviewed has seemed solid and overall opus 5.5 has really impressed me.