Repository navigation
docs(adr): 0047 a break waits for a minor release that a feature brings - #293
Merged
Merged
Conversation
ShortArrow
marked this pull request as ready for review
October 20, 2026 00:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0047 §2 said only that a break of the
--jsonorconfig.tomlcontract needs a minor version. It did not say when a minor version is cut, or whether a change in what a setting does counts as a break. Thetimeout_mschange (#250) fell into that gap. It made unchanged configurations stop slow measurements, and it was prepared as 0.4.1 (#288) before it was moved into 0.5.0 (#291).§2 now says three things.
config.tomlcontract covers what a value does as well as how it is spelled. Under that reading,timeout_msbroke it.main,maincuts no patch release. A fix owed to the current minor line ships from a maintenance branch under ADR 0022's existing rule.The last point follows from the first two. Without it, a patch cut from
mainwould carry the waiting break, which §2 already forbids.