Skip to content

Restrict config file permissions - #1045

Merged
stephanie-shopify merged 1 commit into
mainfrom
fix-config-file-permissions
Sep 25, 2026
Merged

stephanie-shopify merged 1 commit into
mainfrom
fix-config-file-permissions

Conversation

@stephanie-shopify

@stephanie-shopify stephanie-shopify commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Addresses internal Vault issue #80288, which reported that Theme Kit creates password-bearing config files that can be read by other local users.

Config files can contain theme passwords, but newly created files were opened with 0644 permissions. This changes the create mode to 0600 so new config files are only readable and writable by the owner.

Security impact

This fixes a local file-permissions vulnerability for newly created config files. Existing config files are not modified by this change.

Testing

  • go test ./src/env/
  • go test ./...

@stephanie-shopify
stephanie-shopify requested review from a team and graygilmore September 23, 2026 20:54
@stephanie-shopify
stephanie-shopify merged commit b789bf3 into main Sep 25, 2026
1 check passed
@stephanie-shopify
stephanie-shopify deleted the fix-config-file-permissions branch September 25, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants