Repository navigation
Refresh FOG starter schemas from the canonical public contract - #441
Draft
suhshinhwang wants to merge 2 commits into
Draft
suhshinhwang wants to merge 2 commits into
suhshinhwang wants to merge 2 commits into
Conversation
Refresh all three FOG starter schemas from the regenerated unstable public schema. Expose DeliverableLineQuantity and Package.deliverableLineQuantities instead of the removed cart-line membership contract, and keep the remaining public type, enum, and description definitions in sync with Core.
The current Wasm test helpers consume the flat function-info fields returned by Shopify CLI 4.8.2. Pin that CLI version and select Node 22.22.0 explicitly so floating CLI releases cannot change the helper contract and the pinned CLI has a compatible runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Core PR 2334649 removes
Package.lineQuantitiesandLineQuantityfrom the fulfillment option generator API. Package membership usesPackage.deliverableLineQuantities, whosedeliverableLineIdidentifies an entry incart.deliverableLines, notcart.lines.Solution
Refresh the JavaScript/TypeScript, Rust, and Wasm starter schema snapshots from the regenerated unstable public FOG schema at Core commit
d6ddb138fb0c02e6611087cd0bc6126191e70911. Keep the complete canonical SDL, with the templates' existing API-version header, so all three snapshots exposeDeliverableLineQuantityandPackage.deliverableLineQuantitiesand no longer advertise the obsolete membership contract.The complete canonical refresh also removes
App,FulfillmentService,MarketManager,Location.fulfillmentService,Market.manager, andCountryCode.UNKNOWN__; addsCurrencyCode.XCG; deprecatesCurrencyCode.ANG; and updates market descriptions. The starter queries and implementations do not use these removed APIs. Their fetch and run queries remain unchanged because the examples need localization, package handles, and the fetch response, not package membership.Contract dependency
This refresh follows the pre-release contract in Core PR 2334649. FOG has not been released, so no released-app migration is required. Starter-template publication remains separate from Core deployment.
CI toolchain compatibility
Pin the JavaScript, TypeScript, and Rust validation workflows to Shopify CLI
4.8.2on Node22.22.0. The existing test helpers consume CLI 4's flat function-info fields; an unbounded CLI major upgrade can leave schema and target metadata unavailable before fixture validation starts. Selecting a compatible Node runtime separately keeps the pinned CLI usable without changing Function implementations, tests, or schemas.