Skip to content

Refresh FOG starter schemas from the canonical public contract - #441

Draft
suhshinhwang wants to merge 2 commits into
mainfrom
sshwang/fog-deliverable-line-template-schemas
Draft

suhshinhwang wants to merge 2 commits into
mainfrom
sshwang/fog-deliverable-line-template-schemas

Conversation

@suhshinhwang

@suhshinhwang suhshinhwang commented Oct 29, 2026 •

Copy link
Copy Markdown

Background

Core PR 2334649 removes Package.lineQuantities and LineQuantity from the fulfillment option generator API. Package membership uses Package.deliverableLineQuantities, whose deliverableLineId identifies an entry in cart.deliverableLines, not cart.lines.

Solution

Refresh the JavaScript/TypeScript, Rust, and Wasm starter schema snapshots from the regenerated unstable public FOG schema at Core commit d6ddb138fb0c02e6611087cd0bc6126191e70911. Keep the complete canonical SDL, with the templates' existing API-version header, so all three snapshots expose DeliverableLineQuantity and Package.deliverableLineQuantities and no longer advertise the obsolete membership contract.

The complete canonical refresh also removes App, FulfillmentService, MarketManager, Location.fulfillmentService, Market.manager, and CountryCode.UNKNOWN__; adds CurrencyCode.XCG; deprecates CurrencyCode.ANG; and updates market descriptions. The starter queries and implementations do not use these removed APIs. Their fetch and run queries remain unchanged because the examples need localization, package handles, and the fetch response, not package membership.

Contract dependency

This refresh follows the pre-release contract in Core PR 2334649. FOG has not been released, so no released-app migration is required. Starter-template publication remains separate from Core deployment.

CI toolchain compatibility

Pin the JavaScript, TypeScript, and Rust validation workflows to Shopify CLI 4.8.2 on Node 22.22.0. The existing test helpers consume CLI 4's flat function-info fields; an unbounded CLI major upgrade can leave schema and target metadata unavailable before fixture validation starts. Selecting a compatible Node runtime separately keeps the pinned CLI usable without changing Function implementations, tests, or schemas.

Refresh all three FOG starter schemas from the regenerated unstable public schema. Expose DeliverableLineQuantity and Package.deliverableLineQuantities instead of the removed cart-line membership contract, and keep the remaining public type, enum, and description definitions in sync with Core.
The current Wasm test helpers consume the flat function-info fields returned by Shopify CLI 4.8.2. Pin that CLI version and select Node 22.22.0 explicitly so floating CLI releases cannot change the helper contract and the pinned CLI has a compatible runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant