Repository navigation
Conversation
robertcooper-shopify
marked this pull request as ready for review
November 6, 2026 19:46
iphipps
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the reference app from Discount Functions Testing at
f82aa437. The output is committed as generated, with no manual edits.Delivery discounts
The delivery discount functions in the JavaScript and Rust
defaultandmetafieldexamples used to discount onlydeliveryGroups[0]. A cart that splits into a pickup group and a shipping group can list the pickup group first, which put the discount on pickup while shipping kept its full price.They now check every delivery group and discount only the groups with a
SHIPPINGoption. An inline comment marks where to add other delivery methods such asLOCAL. The input queries adddeliveryOptions { deliveryMethodType }, and a cart with no shipping group gets no operations instead of an error. The CLI discount template got the same change in Shopify/function-examples#664.Other generated changes
These came from earlier Discount Functions Testing changes, not this one:
api_versionmoves from2026-01to2026-10in each example'sshopify.extension.toml, with updatedschema.graphqlfiles and generated types.cart_linesfunctions indefaultandmetafieldset the newprerequisitesfield toNone.>=22.22.0to>=22.23.4, with lockfile updates.Validation
defaultexample passes its 11 tests, the Rustdefaultexample passes its 7, and the Rustmetafieldexample builds.